Adding time profiling support to AudioFrame

Adding time profiling support to AudioFrame

BUG=webrtc:8206

[henrika_webrtc, 2017-09-12 08:34:47]

Description was changed from

==========
Adding time profiling support to AudioFrame

Adding time profiling support to AudioFrame


Adding profile timestamps to AudioFrame

BUG=
==========

to

==========
Adding time profiling support to AudioFrame

BUG=webrtc:8206
==========

[henrika_webrtc, 2017-09-12 08:34:47]

henrika@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[henrika_webrtc, 2017-09-12 08:34:58]

PTAL

[hlundin-webrtc, 2017-09-14 13:34:34]

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_types.h (right):

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:345: void UpdateProfileTime();
Suggest UpdateProfileTimestamp to match variable name.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:348: int64_t TimeSinceLastProfile()
const;
Suggest ElapsedProfileTimeMs().

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:387: int64_t profile_time_stamp_ms_
= 0;
The convention in this file is to write timestamp as one word. Thus,
profile_timestamp_ms_.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:479: {
Why the extra braces?

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:480: profile_time_stamp_ms_ =
rtc::TimeMillis()  ;
Delete space before ;

[hlundin-webrtc, 2017-09-14 13:45:39]

+kwiberg, see qq inline.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_types.h (right):

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:385: // by design. Also,
rtc::Optional is not used since it will cause a "complex
+kwiberg@, would you consider this reason enough to create a corresponding .cc
file, or is it too much work?

[henrika_webrtc, 2017-09-15 13:33:58]

Thanks. Moving to new Gerrit CL.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_types.h (right):

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:345: void UpdateProfileTime();
On 2017/09/14 13:34:33, hlundin-webrtc wrote:
> Suggest UpdateProfileTimestamp to match variable name.

Done.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:348: int64_t TimeSinceLastProfile()
const;
On 2017/09/14 13:34:34, hlundin-webrtc wrote:
> Suggest ElapsedProfileTimeMs().

Done.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:385: // by design. Also,
rtc::Optional is not used since it will cause a "complex
IMHO, adding a cc-file for this functionality only feels like overkill.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:387: int64_t profile_time_stamp_ms_
= 0;
On 2017/09/14 13:34:33, hlundin-webrtc wrote:
> The convention in this file is to write timestamp as one word. Thus,
> profile_timestamp_ms_.

Done.

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:479: {
My bad

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:480: profile_time_stamp_ms_ =
rtc::TimeMillis()  ;
On 2017/09/14 13:34:33, hlundin-webrtc wrote:
> Delete space before ;

Done.

[henrika_webrtc, 2017-09-15 13:37:19]

Moved to https://webrtc-review.googlesource.com/c/src/+/1584

[kwiberg-webrtc, 2017-09-15 17:52:29]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-09-15 17:52:30]

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_types.h (right):

https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:385: // by design. Also,
rtc::Optional is not used since it will cause a "complex
On 2017/09/15 13:33:57, henrika_webrtc wrote:
> IMHO, adding a cc-file for this functionality only feels like overkill.

If build targets are set up properly (as they should be, and almost always are
nowadays), adding a .cc file is very little work. So if using Optional is the
right thing to do, don't avoid it just because you'll need a .cc file.

[guptaromi2529, 2017-09-28 04:44:03]

http://printablecalendartemplates.com/official-business-letter-example/
Find here all templates

[guptaromi2529, 2017-09-28 04:44:04]

http://printablecalendartemplates.com/official-business-letter-example/
Find here all templates