Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: webrtc/rtc_base/BUILD.gn

Issue 3003643002: Allow external TaskQueue implementations on Linux (Closed)
Patch Set: .. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/rtc_base/task_queue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/BUILD.gn
diff --git a/webrtc/rtc_base/BUILD.gn b/webrtc/rtc_base/BUILD.gn
index 60d1f57583cf9f86f0d74ac6c63484d30a5f39c6..8a64b3244831141ed0bb9f432caa445bfde87e8a 100644
--- a/webrtc/rtc_base/BUILD.gn
+++ b/webrtc/rtc_base/BUILD.gn
@@ -294,42 +294,71 @@ config("enable_libevent_config") {
defines = [ "WEBRTC_BUILD_LIBEVENT" ]
}
-rtc_static_library("rtc_task_queue") {
+rtc_source_set("rtc_task_queue") {
public_deps = [
":rtc_base_approved",
+ ":rtc_task_queue_api",
]
+ if (rtc_link_task_queue_impl) {
+ deps = [
+ ":rtc_task_queue_impl",
+ ]
+ }
+}
+
+# WebRTC targets must not directly depend on rtc_task_queue_api or
+# rtc_task_queue_impl. Instead, depend on rtc_task_queue.
+# The build flag |rtc_link_task_queue_impl| decides if WebRTC targets will link
+# to the default implemenation in rtc_task_queue_impl or if an externally
+# provided implementation should be used. An external implementation should
+# depend on rtc_task_queue_api.
+rtc_source_set("rtc_task_queue_api") {
if (build_with_chromium) {
sources = [
- "../../webrtc_overrides/webrtc/rtc_base/task_queue.cc",
"../../webrtc_overrides/webrtc/rtc_base/task_queue.h",
]
} else {
sources = [
"task_queue.h",
- "task_queue_posix.h",
]
+ }
+ deps = [
+ ":rtc_base_approved",
+ ]
+}
+
+rtc_source_set("rtc_task_queue_impl") {
+ deps = [
+ ":rtc_base_approved",
+ ":rtc_task_queue_api",
+ ]
+ if (build_with_chromium) {
+ sources = [
+ "../../webrtc_overrides/webrtc/rtc_base/task_queue.cc",
+ ]
+ } else {
if (rtc_build_libevent) {
- deps = [
- "//base/third_party/libevent",
- ]
+ deps += [ "//base/third_party/libevent" ]
}
-
if (rtc_enable_libevent) {
- sources += [
+ sources = [
"task_queue_libevent.cc",
"task_queue_posix.cc",
+ "task_queue_posix.h",
]
all_dependent_configs = [ ":enable_libevent_config" ]
} else {
if (is_mac || is_ios) {
- sources += [
+ sources = [
"task_queue_gcd.cc",
"task_queue_posix.cc",
]
}
if (is_win) {
- sources += [ "task_queue_win.cc" ]
+ sources = [
+ "task_queue_win.cc",
+ ]
}
}
}
« no previous file with comments | « no previous file | webrtc/rtc_base/task_queue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698