Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

Issue 3003173002: Remove more references to AnalysisContext (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart b/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
index 133bd70fd78eefd9cbc71ec9fc2669016d2a527d..2277f99ff2b80642a17879ead3934c9dcaeac431 100644
--- a/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
+++ b/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
@@ -17,7 +17,6 @@ import 'package:analyzer/src/dart/ast/utilities.dart';
import 'package:analyzer/src/dart/error/hint_codes.dart';
import 'package:analyzer/src/dart/error/syntactic_errors.dart';
import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer_plugin/utilities/range_factory.dart';
@@ -134,9 +133,7 @@ class StatementCompletionProcessor {
DartStatementCompletion.NO_COMPLETION, new SourceChange("", edits: []));
final StatementCompletionContext statementContext;
- final AnalysisContext analysisContext;
final CorrectionUtils utils;
- int fileStamp;
AstNode node;
StatementCompletion completion;
SourceChange change = new SourceChange('statement-completion');
@@ -146,10 +143,7 @@ class StatementCompletionProcessor {
Position exitPosition = null;
StatementCompletionProcessor(this.statementContext)
- : analysisContext = statementContext.unitElement.context,
- utils = new CorrectionUtils(statementContext.unit) {
- fileStamp = analysisContext.getModificationStamp(source);
- }
+ : utils = new CorrectionUtils(statementContext.unit);
String get eol => utils.endOfLine;
@@ -168,11 +162,6 @@ class StatementCompletionProcessor {
CompilationUnitElement get unitElement => statementContext.unitElement;
Future<StatementCompletion> compute() async {
- // If the source was changed between the constructor and running
- // this asynchronous method, it is not safe to use the unit.
- if (analysisContext.getModificationStamp(source) != fileStamp) {
- return NO_COMPLETION;
- }
node = _selectedNode();
if (node == null) {
return NO_COMPLETION;

Powered by Google App Engine
This is Rietveld 408576698