Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Issue 3003153002: Make generic-set-span support URLs. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Make generic-set-span support URLs. Currently, generic-set-span displays strings as plain text without using generic-object-view in order to avoid the visual noise of the JSON. However, it does not linkify URLs, which are strings. This CL linkifies URLs. Review-Url: https://codereview.chromium.org/3003153002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/454be6747cda541121b77ac9b7b5c2bb7f92c050

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M tracing/tracing/value/ui/generic_set_span.html View 2 chunks +21 lines, -1 line 0 comments Download
M tracing/tracing/value/ui/generic_set_span_test.html View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-22 19:34:21 UTC) #3
eakuefner
lgtm
3 years, 4 months ago (2017-08-23 16:56:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3003153002/20001
3 years, 4 months ago (2017-08-23 17:03:13 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-23 17:48:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698