Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: pkg/kernel/lib/transformations/closure/converter.dart

Issue 3000333002: Fix several bugs in closure conversion. (Closed)
Patch Set: Comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/kernel/lib/transformations/closure/invalidate_closures.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/transformations/closure/converter.dart
diff --git a/pkg/kernel/lib/transformations/closure/converter.dart b/pkg/kernel/lib/transformations/closure/converter.dart
index 42def515583d11852bb3139399e9ea55655981c2..0824b432e9c3a4afcc25579d19bb7b51fca33d25 100644
--- a/pkg/kernel/lib/transformations/closure/converter.dart
+++ b/pkg/kernel/lib/transformations/closure/converter.dart
@@ -6,6 +6,7 @@ library kernel.transformations.closure.converter;
import '../../ast.dart'
show
+ AsyncMarker,
Arguments,
Block,
Catch,
@@ -13,6 +14,7 @@ import '../../ast.dart'
ClosureCreation,
Constructor,
DartType,
+ DoStatement,
EmptyStatement,
Expression,
ExpressionStatement,
@@ -52,6 +54,7 @@ import '../../ast.dart'
VariableSet,
VectorCreation,
VectorType,
+ WhileStatement,
transformList;
import '../../frontend/accessors.dart' show VariableAccessor;
@@ -70,6 +73,13 @@ import 'info.dart' show ClosureInfo;
import 'rewriter.dart' show AstRewriter, BlockRewriter, InitializerListRewriter;
+bool isLoop(TreeNode node) {
+ return node is WhileStatement ||
+ node is DoStatement ||
+ node is ForStatement ||
+ node is ForInStatement;
+}
+
class ClosureConverter extends Transformer {
final CoreTypes coreTypes;
@@ -347,6 +357,10 @@ class ClosureConverter extends Transformer {
}
Expression handleLocalFunction(FunctionNode function) {
+ if (function.asyncMarker == AsyncMarker.SyncYielding) {
+ function.transformChildren(this);
+ return new FunctionExpression(function);
+ }
FunctionNode enclosingFunction = currentFunction;
Map<TypeParameter, DartType> enclosingTypeSubstitution = typeSubstitution;
currentFunction = function;
@@ -554,6 +568,11 @@ class ClosureConverter extends Transformer {
TreeNode visitBlock(Block node) {
return saveContext(() {
BlockRewriter blockRewriter = rewriter = rewriter.forNestedBlock(node);
+ if (node.parent is Statement &&
+ isLoop(node.parent) &&
+ context is! NoContext) {
+ context = context.toNestedContext();
+ }
blockRewriter.transformStatements(this);
return node;
});
« no previous file with comments | « no previous file | pkg/kernel/lib/transformations/closure/invalidate_closures.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698