Optimize DDC private library files.

pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._js_helper;
 
 // Helper method used by internal libraries.
 regExpGetNative(JSSyntaxRegExp regexp) => regexp._nativeRegExp;
 
-List<String> _stringList(List l) => l == null ? l : new JSArray<String>.of(l);
-
 /**
  * Returns a native version of the RegExp with the global flag set.
  *
  * The RegExp's `lastIndex` property is zero when it is returned.
  *
  * The returned regexp is shared, and its `lastIndex` property may be
  * modified by other uses, so the returned regexp must be used immediately
  * when it's returned, with no user-provided code run in between.
  */
 regExpGetGlobalNative(JSSyntaxRegExp regexp) {
   var nativeRegexp = regexp._nativeGlobalVersion;
   JS("void", "#.lastIndex = 0", nativeRegexp);
   return nativeRegexp;
 }
 
 /**
  * Computes the number of captures in a regexp.
  *
  * This currently involves creating a new RegExp object with a different
  * source and running it against the empty string (the last part is usually
  * fast).
  *
  * The JSSyntaxRegExp could cache the result, and set the cache any time
  * it finds a match.
  */
 int regExpCaptureCount(JSSyntaxRegExp regexp) {
   var nativeAnchoredRegExp = regexp._nativeAnchoredVersion;
-  var match = JS('JSExtendableArray', "#.exec('')", nativeAnchoredRegExp);
+  JSExtendableArray match =
+      JS('JSExtendableArray', "#.exec('')", nativeAnchoredRegExp);
   // The native-anchored regexp always have one capture more than the original,
   // and always matches the empty string.
   return match.length - 2;
 }
 
 class JSSyntaxRegExp implements RegExp {
   final String pattern;
   final _nativeRegExp;
   var _nativeGlobalRegExp;
   var _nativeAnchoredRegExp;
@@ skipping 19 matching lines @@
     // that it tries, and you can see if the original regexp matched, or it
     // was the added zero-width match that matched, by looking at the last
     // capture. If it is a String, the match participated, otherwise it didn't.
     return _nativeAnchoredRegExp =
         makeNative("$pattern|()", _isMultiLine, _isCaseSensitive, true);
   }
 
   bool get _isMultiLine => JS("bool", "#.multiline", _nativeRegExp);
   bool get _isCaseSensitive => JS("bool", "!#.ignoreCase", _nativeRegExp);
 
-  static makeNative(
-      String source, bool multiLine, bool caseSensitive, bool global) {
-    checkString(source);
+  static makeNative(@nullCheck String source, bool multiLine,
+      bool caseSensitive, bool global) {
     String m = multiLine ? 'm' : '';
     String i = caseSensitive ? '' : 'i';
     String g = global ? 'g' : '';
     // We're using the JavaScript's try catch instead of the Dart one
     // to avoid dragging in Dart runtime support just because of using
     // RegExp.
     var regexp = JS(
         '',
         '(function() {'
         'try {'
         'return new RegExp(#, # + # + #);'
         '} catch (e) {'
         'return e;'
         '}'
         '})()',
         source,
         m,
         i,
         g);
     if (JS('bool', '# instanceof RegExp', regexp)) return regexp;
     // The returned value is the JavaScript exception. Turn it into a
     // Dart exception.
     String errorMessage = JS('String', r'String(#)', regexp);
     throw new FormatException("Illegal RegExp pattern: $source, $errorMessage");
   }
 
-  Match firstMatch(String string) {
-    List m = JS('JSExtendableArray|Null', r'#.exec(#)', _nativeRegExp,
-        checkString(string));
+  Match firstMatch(@nullCheck String string) {
+    List m = JS('JSExtendableArray|Null', r'#.exec(#)', _nativeRegExp, string);
     if (m == null) return null;
-    return new _MatchImplementation(this, _stringList(m));
+    return new _MatchImplementation(this, new JSArray<String>.of(m));
   }
 
-  bool hasMatch(String string) {
-    return JS('bool', r'#.test(#)', _nativeRegExp, checkString(string));
+  @notNull
+  bool hasMatch(@nullCheck String string) {
+    return JS('bool', r'#.test(#)', _nativeRegExp, string);
   }
 
   String stringMatch(String string) {
     var match = firstMatch(string);
     if (match != null) return match.group(0);
     return null;
   }
 
-  Iterable<Match> allMatches(String string, [int start = 0]) {
-    checkString(string);
-    checkInt(start);
+  Iterable<Match> allMatches(@nullCheck String string,
+      [@nullCheck int start = 0]) {
     if (start < 0 || start > string.length) {
       throw new RangeError.range(start, 0, string.length);
     }
     return new _AllMatchesIterable(this, string, start);
   }
 
   Match _execGlobal(String string, int start) {
     Object regexp = _nativeGlobalVersion;
     JS("void", "#.lastIndex = #", regexp, start);
     List match = JS("JSExtendableArray|Null", "#.exec(#)", regexp, string);
     if (match == null) return null;
-    return new _MatchImplementation(this, _stringList(match));
+    return new _MatchImplementation(this, new JSArray<String>.of(match));
   }
 
   Match _execAnchored(String string, int start) {
     Object regexp = _nativeAnchoredVersion;
     JS("void", "#.lastIndex = #", regexp, start);
     List match = JS("JSExtendableArray|Null", "#.exec(#)", regexp, string);
     if (match == null) return null;
     // If the last capture group participated, the original regexp did not
     // match at the start position.
     if (match[match.length - 1] != null) return null;
     match.length -= 1;
-    return new _MatchImplementation(this, _stringList(match));
+    return new _MatchImplementation(this, new JSArray<String>.of(match));
   }
 
   Match matchAsPrefix(String string, [int start = 0]) {
     if (start < 0 || start > string.length) {
       throw new RangeError.range(start, 0, string.length);
     }
     return _execAnchored(string, start);
   }
 
   bool get isMultiLine => _isMultiLine;
@@ skipping 65 matching lines @@
     _current = null;
     _string = null; // Marks iteration as ended.
     return false;
   }
 }
 
 /** Find the first match of [regExp] in [string] at or after [start]. */
 Match firstMatchAfter(JSSyntaxRegExp regExp, String string, int start) {
   return regExp._execGlobal(string, start);
 }