Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2963593002: Split DumpPixelsAsync in pixel_dump.h into more granular functions. (Closed)
Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/test_runner/pixel_dump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 4a6ef125a80f95d3d4cafb18f9eadecb2d9b0fca..e5dc0f7789556e8f856e4ab21fd028f0f8ec5425 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -923,8 +923,13 @@ void BlinkTestRunner::CaptureDumpContinued() {
interfaces->TestRunner()->ShouldGeneratePixelResults() &&
!interfaces->TestRunner()->ShouldDumpAsAudio()) {
CHECK(render_view()->GetWebView()->IsAcceleratedCompositingActive());
+
+ // Test finish should only be processed in the BlinkTestRunner associated
+ // with the current, non-swapped-out RenderView.
+ DCHECK(render_view()->GetWebView()->MainFrame()->IsWebLocalFrame());
+
interfaces->TestRunner()->DumpPixelsAsync(
- render_view()->GetWebView(),
+ render_view()->GetWebView()->MainFrame()->ToWebLocalFrame(),
base::Bind(&BlinkTestRunner::OnPixelsDumpCompleted,
base::Unretained(this)));
return;
« no previous file with comments | « no previous file | content/shell/test_runner/pixel_dump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698