Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc

Issue 2961533002: Add "AllArticles" mode to Reader Mode heuristics (Closed)
Patch Set: Revert "exclude ios" Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
diff --git a/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc b/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
index 83085ff0c71de4ab2ba1208236eddcbcbe2df8ac..23fe58dd92337f5884d562e7b6be8d8e5c050bda 100644
--- a/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
+++ b/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
@@ -203,4 +203,26 @@ IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestAdaboost,
}
}
+using DistillablePageUtilsBrowserTestAllArticles =
+ DistillablePageUtilsBrowserTestOption<kAllArticles>;
+
+IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestAllArticles,
+ TestDelegate) {
+ const char* paths[] = {kSimpleArticlePath, kSimpleArticleIFramePath};
+ for (unsigned i = 0; i < sizeof(paths) / sizeof(paths[0]); ++i) {
+ testing::InSequence dummy;
+ EXPECT_CALL(holder_, OnResult(true, false)).Times(1);
+ EXPECT_CALL(holder_, OnResult(true, true))
+ .WillOnce(testing::InvokeWithoutArgs(QuitSoon));
+ NavigateAndWait(paths[i], 0);
+ }
+ {
+ testing::InSequence dummy;
+ EXPECT_CALL(holder_, OnResult(false, false)).Times(1);
+ EXPECT_CALL(holder_, OnResult(false, true))
+ .WillOnce(testing::InvokeWithoutArgs(QuitSoon));
+ NavigateAndWait(kNonArticlePath, 0);
+ }
+}
+
} // namespace dom_distiller
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698