Remove UMA.Debug.EnableCrashUpload.* UMA,

Remove UMA.Debug.EnableCrashUpload.* UMA.
Replace isRunningApplicationStart with hasComeToForeground.

BUG=711708
Review-Url: https://codereview.chromium.org/2960843003
Cr-Commit-Position: refs/heads/master@{#483073}
Committed: https://chromium.googlesource.com/chromium/src/+/abade4578be9f49dee1fdfe1a80ccdaa3ca3f386

[Ran, 2017-06-27 15:33:30]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 15:33:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ran, 2017-06-27 15:39:26]

Description was changed from

==========
Remove UMA.Debug.EnableCrashUpload.* UMA,
replace isRunningApplicationStart by hasComeToForeground

BUG=711708
==========

to

==========
Remove UMA.Debug.EnableCrashUpload.* UMA.
Replace isRunningApplicationStart with hasComeToForeground.

BUG=711708
==========

[Ran, 2017-06-27 15:47:07]

ranj@chromium.org changed reviewers:
+ wnwen@chromium.org, yfriedman@chromium.org

[commit-bot: I haz the power, 2017-06-27 17:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 17:22:15]

Dry run: This issue passed the CQ dry run.

[Yaron, 2017-06-27 18:26:27]

yfriedman@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Yaron, 2017-06-27 18:26:28]

asvitkine should review since he added them.

Having read the bug (and paged it back in!) I actually think some of the
deferred metrics are interesting. I don't know if they're entirely actionable
though in that nobody is actively looking at them, and we do already have
metrics for if it certain items are taking a long time to do deferred startup
(UMA.Debug.EnableCrashUpload.DeferredStartUpMaxTaskDuration,
UMA.Debug.EnableCrashUpload.DeferredStartUpAsyncTaskDuration).

I'd suggest we keep DeferredStartUpCompleteTime (just add the relevant guard)
because if you're adding something there that's time-sensitive for the user,
it's good to know how long they'd have to wait

[Ran, 2017-06-28 14:29:18]

On 2017/06/27 18:26:28, Yaron wrote:
> asvitkine should review since he added them.
> 
> Having read the bug (and paged it back in!) I actually think some of the
> deferred metrics are interesting. I don't know if they're entirely actionable
> though in that nobody is actively looking at them, and we do already have
> metrics for if it certain items are taking a long time to do deferred startup
> (UMA.Debug.EnableCrashUpload.DeferredStartUpMaxTaskDuration,
> UMA.Debug.EnableCrashUpload.DeferredStartUpAsyncTaskDuration).
> 
> I'd suggest we keep DeferredStartUpCompleteTime (just add the relevant guard)
> because if you're adding something there that's time-sensitive for the user,
> it's good to know how long they'd have to wait

So I will keep DeferredStartUpCompleteTime metric if there is no objection.
What is the initial thought to delete them?

[Peter Wen, 2017-06-28 15:11:24]

On 2017/06/28 14:29:18, Ran wrote:
> On 2017/06/27 18:26:28, Yaron wrote:
> > asvitkine should review since he added them.
> > 
> > Having read the bug (and paged it back in!) I actually think some of the
> > deferred metrics are interesting. I don't know if they're entirely
actionable
> > though in that nobody is actively looking at them, and we do already have
> > metrics for if it certain items are taking a long time to do deferred
startup
> > (UMA.Debug.EnableCrashUpload.DeferredStartUpMaxTaskDuration,
> > UMA.Debug.EnableCrashUpload.DeferredStartUpAsyncTaskDuration).
> > 
> > I'd suggest we keep DeferredStartUpCompleteTime (just add the relevant
guard)
> > because if you're adding something there that's time-sensitive for the user,
> > it's good to know how long they'd have to wait
> 
> So I will keep DeferredStartUpCompleteTime metric if there is no objection.
> What is the initial thought to delete them?

lgtm % comments

The initial thought was that we could delete all of them and not need a
"hasComeToForeground" at all, but since we're keeping it for the startup metrics
anyways, doesn't hurt to keep the Complete time metric too.

Good job getting ramped up so quickly!

[Peter Wen, 2017-06-28 15:11:43]

Forgot to send comments

https://codereview.chromium.org/2960843003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2960843003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:2069:
mDeferredStartupPosted = true;
Would be good to clean this up and move this check into onDeferredStartup to
ensure it's only ever run once.

https://codereview.chromium.org/2960843003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2960843003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:79137: +    Deprecated 2017. No longer
tracked.
Remember to remove this when keeping this stat.

[Ran, 2017-06-28 16:10:08]

Patchset #2 (id:20001) has been deleted

[Ran, 2017-06-28 16:20:15]

Patchset #2 (id:40001) has been deleted

[Ran, 2017-06-28 16:24:30]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 16:24:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ran, 2017-06-28 16:29:15]

Fix

https://codereview.chromium.org/2960843003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2960843003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:2069:
mDeferredStartupPosted = true;
On 2017/06/28 15:11:42, Peter Wen wrote:
> Would be good to clean this up and move this check into onDeferredStartup to
> ensure it's only ever run once.

Done.

https://codereview.chromium.org/2960843003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2960843003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:79137: +    Deprecated 2017. No longer
tracked.
On 2017/06/28 15:11:43, Peter Wen wrote:
> Remember to remove this when keeping this stat.

Done.

[Yaron, 2017-06-28 16:52:50]

lgtm

[Alexei Svitkine (slow), 2017-06-28 16:55:50]

lgtm

[commit-bot: I haz the power, 2017-06-28 18:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:20:25]

Dry run: This issue passed the CQ dry run.

[Ran, 2017-06-28 18:22:59]

The CQ bit was checked by ranj@chromium.org

[Ran, 2017-06-28 18:22:59]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2960843003/#ps60001
(title: "Keep DeferredStartUpCompleteTime metrics")

[commit-bot: I haz the power, 2017-06-28 18:23:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:29:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498674179089440,
"parent_rev": "406899d78bedbdb4d09f65f65991126e61a8e758", "commit_rev":
"abade4578be9f49dee1fdfe1a80ccdaa3ca3f386"}

[commit-bot: I haz the power, 2017-06-28 18:30:09]

Description was changed from

==========
Remove UMA.Debug.EnableCrashUpload.* UMA.
Replace isRunningApplicationStart with hasComeToForeground.

BUG=711708
==========

to

==========
Remove UMA.Debug.EnableCrashUpload.* UMA.
Replace isRunningApplicationStart with hasComeToForeground.

BUG=711708

Review-Url: https://codereview.chromium.org/2960843003
Cr-Commit-Position: refs/heads/master@{#483073}
Committed:
https://chromium.googlesource.com/chromium/src/+/abade4578be9f49dee1fdfe1a80c...
==========

[commit-bot: I haz the power, 2017-06-28 18:30:12]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/abade4578be9f49dee1fdfe1a80c...