Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2959743004: Add comment warning about modifying landmines (Closed)

Created:
3 years, 5 months ago by brucedawson
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment warning about modifying landmines Modifying landmines has greater consequences than is sometimes realized for developers, especially on Windows. Add a comment to warn editors of these consequences. This was inspired by https://chromium-review.googlesource.com/c/544867/ R=dpranke@chromium.org BUG=736939 Review-Url: https://codereview.chromium.org/2959743004 Cr-Commit-Position: refs/heads/master@{#482639} Committed: https://chromium.googlesource.com/chromium/src/+/46ac6b742672a82001cd3d8ef0c7525be72a9097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/landmines.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
brucedawson
Does this seem appropriate? We could also assign explicit OWNERS to further discourage landmines. I ...
3 years, 5 months ago (2017-06-26 23:44:11 UTC) #3
Dirk Pranke
I think this looks fine (lgtm) though I don't think it'll matter much. Apart from ...
3 years, 5 months ago (2017-06-27 00:32:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959743004/1
3 years, 5 months ago (2017-06-27 16:01:07 UTC) #9
brucedawson
On 2017/06/27 00:32:21, Dirk Pranke wrote: > I think this looks fine (lgtm) though I ...
3 years, 5 months ago (2017-06-27 16:02:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/46ac6b742672a82001cd3d8ef0c7525be72a9097
3 years, 5 months ago (2017-06-27 16:05:06 UTC) #13
Nico
Do you think anyone will look at this file? landmines are added to get_landmines.py, which ...
3 years, 5 months ago (2017-06-27 16:09:21 UTC) #15
brucedawson
3 years, 5 months ago (2017-06-27 17:47:31 UTC) #16
Message was sent while issue was closed.
On 2017/06/27 16:09:21, Nico (vacation Jun 30-Jul 11) wrote:
> Do you think anyone will look at this file? landmines are added to
> get_landmines.py, which already has a comment like this. I suppose we could
copy
> the comment in get_landmines.py from the top to the bottom too, so it's more
in
> sight.
> 
> But adding the comment to this file seems unlikely to help.

Drat. Yep, wrong file. I'll add the warnings to the correct file.

Powered by Google App Engine
This is Rietveld 408576698