Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2959743003: Rerecorded browse:news:toi (Closed)

Created:
3 years, 5 months ago by ashleymarie1
Modified:
3 years, 5 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rerecorded browse:news:toi BUG=chromium:728081 Review-Url: https://codereview.chromium.org/2959743003 Cr-Commit-Position: refs/heads/master@{#482663} Committed: https://chromium.googlesource.com/chromium/src/+/7c12598ed00f30cc125b9af98a7826edcbf47a39

Patch Set 1 #

Patch Set 2 : removing test from disabled list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 2 chunks +2 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_064.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/expectations.py View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
ashleymarie1
3 years, 5 months ago (2017-06-26 19:00:58 UTC) #10
nednguyen
On 2017/06/26 19:00:58, ashleymarie1 wrote: You also need to remove https://cs.chromium.org/chromium/src/tools/perf/benchmarks/system_health_smoke_test.py?rcl=86716087cc70f251aad2111ec6d86711239c44ab&l=38
3 years, 5 months ago (2017-06-26 19:02:11 UTC) #11
ashleymarie1
On 2017/06/26 19:02:11, nednguyen wrote: > On 2017/06/26 19:00:58, ashleymarie1 wrote: > > You also ...
3 years, 5 months ago (2017-06-27 14:55:59 UTC) #16
nednguyen
On 2017/06/27 14:55:59, ashleymarie1 wrote: > On 2017/06/26 19:02:11, nednguyen wrote: > > On 2017/06/26 ...
3 years, 5 months ago (2017-06-27 14:57:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959743003/20001
3 years, 5 months ago (2017-06-27 17:21:28 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7c12598ed00f30cc125b9af98a7826edcbf47a39
3 years, 5 months ago (2017-06-27 17:25:38 UTC) #22
ashleymarie1
3 years, 5 months ago (2017-06-28 13:16:59 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2961013003/ by ashleymarie@chromium.org.

The reason for reverting is: Looks like this recording didn't fix the bug
It's running and failing here:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf/....

Powered by Google App Engine
This is Rietveld 408576698