Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2958093002: [Perf] Update references to telemetry.core.discover (Closed)

Created:
3 years, 5 months ago by eakuefner
Modified:
3 years, 5 months ago
CC:
chromium-reviews, imcheng+watch_chromium.org, mfoltz+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Perf] Update references to telemetry.core.discover The discover module has moved to py_utils as of https://codereview.chromium.org/2941123002 and a shim has been left in its place. To remove the shim, we need to update the references on the Chromium side. BUG=catapult:#3612 Review-Url: https://codereview.chromium.org/2958093002 Cr-Commit-Position: refs/heads/master@{#484317} Committed: https://chromium.googlesource.com/chromium/src/+/cee327f18ecc5979a9f589502a3e6361085b3ecc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/pagesets/__init__.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/live_tests/pagesets/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/system_health_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/contrib/cluster_telemetry/multipage_skpicture_printer.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/contrib/cluster_telemetry/skpicture_printer.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/core/benchmark_finders.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/core/find_dependencies.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/core/perf_data_generator.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/measurement_smoke_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/infinite_scroll_cases.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/system_health/system_health_stories.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/profile_creators/profile_generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
eakuefner
+imcheng for chrome/test/media_router change +bustamante for tools/chrome_proxy changes +nednguyen for tools/perf changes Please, take a ...
3 years, 5 months ago (2017-06-27 17:05:57 UTC) #2
imcheng
chrome/test/media_router/telemetry/benchmarks/pagesets/__init__.py lgtm
3 years, 5 months ago (2017-06-27 17:08:39 UTC) #3
nednguyen
lgtm
3 years, 5 months ago (2017-06-27 17:20:02 UTC) #4
eakuefner
bustamante: Friendly ping on tools/chrome_proxy
3 years, 5 months ago (2017-06-30 16:29:58 UTC) #5
eakuefner
bengr: bustamante is OOO; can you stamp for tools/chrome_proxy?
3 years, 5 months ago (2017-07-05 17:11:19 UTC) #7
bengr
lgtm
3 years, 5 months ago (2017-07-05 17:13:04 UTC) #8
eakuefner
Thanks!
3 years, 5 months ago (2017-07-05 17:14:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958093002/1
3 years, 5 months ago (2017-07-05 17:15:03 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 18:34:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cee327f18ecc5979a9f589502a3e...

Powered by Google App Engine
This is Rietveld 408576698