Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/security_interstitials/core/ssl_error_ui.cc

Issue 2955503002: Make interstitial links open in a new tab (Closed)
Patch Set: Fix compilation error Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/ssl_error_ui.cc
diff --git a/components/security_interstitials/core/ssl_error_ui.cc b/components/security_interstitials/core/ssl_error_ui.cc
index c982474692fa9e86c5fecab1e3de5cbb3ef68a09..d4f74ae347a286bc7c3e33ccce49b99df16c1ec1 100644
--- a/components/security_interstitials/core/ssl_error_ui.cc
+++ b/components/security_interstitials/core/ssl_error_ui.cc
@@ -15,8 +15,8 @@
namespace security_interstitials {
namespace {
-// URL for help page.
-const char kHelpURL[] = "https://support.google.com/chrome/answer/6098869";
+// Path to the relevant help center page.
+const char kHelpPath[] = "answer/6098869";
bool IsMasked(int options, SSLErrorUI::SSLErrorOptionsMask mask) {
return ((options & mask) != 0);
@@ -190,7 +190,8 @@ void SSLErrorUI::HandleCommand(SecurityInterstitialCommands command) {
case CMD_OPEN_HELP_CENTER:
controller_->metrics_helper()->RecordUserInteraction(
security_interstitials::MetricsHelper::SHOW_LEARN_MORE);
- controller_->OpenUrlInCurrentTab(GURL(kHelpURL));
+ controller_->OpenUrlInNewForegroundTab(
+ controller_->GetBaseHelpCenterUrl().Resolve(kHelpPath));
break;
case CMD_RELOAD:
controller_->metrics_helper()->RecordUserInteraction(

Powered by Google App Engine
This is Rietveld 408576698