Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/security_interstitials/core/controller_client.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)
Patch Set: Fix compilation error Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 613c6bc9f7f6c53cf0c9911e66ae3f6ae4df361f..ea3e214790d8b5e78ce691623a3478c401e05bc9 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -9,8 +9,8 @@
#include <string>
#include "base/macros.h"
+#include "url/gurl.h"
-class GURL;
class PrefService;
namespace security_interstitials {
@@ -89,15 +89,23 @@ class ControllerClient {
virtual void OpenUrlInCurrentTab(const GURL& url) = 0;
+ virtual void OpenUrlInNewForegroundTab(const GURL& url) = 0;
+
virtual PrefService* GetPrefService() = 0;
virtual const std::string& GetApplicationLocale() const = 0;
+ GURL GetBaseHelpCenterUrl() const;
+
+ void SetBaseHelpCenterUrlForTesting(const GURL& test_url);
+
protected:
virtual const std::string GetExtendedReportingPrefName() const = 0;
private:
std::unique_ptr<MetricsHelper> metrics_helper_;
+ // Link to the help center.
+ GURL help_center_url_;
DISALLOW_COPY_AND_ASSIGN(ControllerClient);
};

Powered by Google App Engine
This is Rietveld 408576698