content/shell/common/layout_test.mojom - Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/common/layout_test.mojom

Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse. (Closed)

Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/common/layout_test.mojom

diff --git a/content/shell/common/layout_test.mojom b/content/shell/common/layout_test.mojom

index dd61553f4ecc53ef400cb7fb93457871bbca441e..19146dd52f7eb4ecc940b1c224bdb98694e00f68 100644

--- a/content/shell/common/layout_test.mojom

+++ b/content/shell/common/layout_test.mojom

@@ -35,9 +35,8 @@ struct ShellTestConfiguration {

};

interface LayoutTestControl {

- // Asks a frame to dump its contents into a string and send them back over

- // IPC.

- LayoutDumpRequest();

+ // Dumps the frame's contents into a string.

+ DumpFrameLayout() => (string frame_layout_dump);

// Replicates test config (for an already started test) to a new renderer

// that hosts parts of the main test window.