Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2952363003: Handle toString on DOM types (Closed)

Created:
3 years, 6 months ago by vsm
Modified:
3 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 13

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/interceptors.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 2 chunks +2 lines, -10 lines 0 comments Download
M tests/lib_strong/html/private_extension_member_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vsm
https://codereview.chromium.org/2952363003/diff/1/tests/lib_strong/html/private_extension_member_test.dart File tests/lib_strong/html/private_extension_member_test.dart (right): https://codereview.chromium.org/2952363003/diff/1/tests/lib_strong/html/private_extension_member_test.dart#newcode16 tests/lib_strong/html/private_extension_member_test.dart:16: Expect.equals("[object DocumentFragment]", Note: this test was added (only to ...
3 years, 6 months ago (2017-06-23 13:59:47 UTC) #2
Jennifer Messerly
seems good but I have some thoughts. We might be able to rethink toString in ...
3 years, 6 months ago (2017-06-23 18:27:11 UTC) #3
vsm
thanks! https://codereview.chromium.org/2952363003/diff/1/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart File pkg/dev_compiler/tool/input_sdk/private/js_helper.dart (right): https://codereview.chromium.org/2952363003/diff/1/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart#newcode188 pkg/dev_compiler/tool/input_sdk/private/js_helper.dart:188: /// In minified mode, uses the unminified names ...
3 years, 5 months ago (2017-06-26 20:29:24 UTC) #4
Jennifer Messerly
lgtm!
3 years, 5 months ago (2017-06-27 00:06:00 UTC) #5
vsm
3 years, 5 months ago (2017-06-27 16:22:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
fd6164cce40d3893fea9766ea16009c1e1aae134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698