runtime/vm/raw_object_snapshot.cc - Issue 2952193002: VM: Speed up output of UTF8 for 1-byte strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 2952193002: VM: Speed up output of UTF8 for 1-byte strings.

Patch Set: Add test that would have caught bug pointed out by Slava Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/raw_object_snapshot.cc

diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc

index 86d033d5dfaf55eb907f5ba3bcc1e21f23ec473d..d4b15a03b5d36e4b7b90a614cdf73ccf128ea111 100644

--- a/runtime/vm/raw_object_snapshot.cc

+++ b/runtime/vm/raw_object_snapshot.cc

@@ -1986,7 +1986,7 @@ void String::ReadFromImpl(SnapshotReader* reader,

return;

}

NoSafepointScope no_safepoint;

- CharacterType* str_addr = StringType::CharAddr(*str_obj, 0);

+ CharacterType* str_addr = StringType::DataStart(*str_obj);

for (intptr_t i = 0; i < len; i++) {

*str_addr = reader->Read<CharacterType>();

str_addr++;

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/symbols.cc » ('j') | no next file with comments »