Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2951913002: [DevTools] Support multiple sessions in Target domain (Closed)
Patch Set: simplify Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index d2c1c88d14cee432d31abfeaea01437e4843fdac..e7546b6fd3b5abe4c724e2744369b9f8be8a3f8a 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -3551,6 +3551,10 @@
"id": "TargetID",
"type": "string"
},
+ {
+ "id": "SessionID",
+ "type": "string"
+ },
{
"id": "BrowserContextID",
"type": "string"
@@ -3605,9 +3609,9 @@
},
{
"name": "sendMessageToTarget",
- "description": "Sends protocol message to the target with given id.",
+ "description": "Sends protocol message to the session with given id.",
"parameters": [
- { "name": "targetId", "$ref": "TargetID" },
+ { "name": "sessionId", "$ref": "SessionID" },
{ "name": "message", "type": "string" }
]
},
@@ -3645,14 +3649,14 @@
{ "name": "targetId", "$ref": "TargetID" }
],
"returns": [
- { "name": "success", "type": "boolean", "description": "Whether attach succeeded." }
+ { "name": "sessionId", "$ref": "SessionID", "optional": true, "description": "Id assigned to the session, only present if attached successfully." }
]
},
{
"name": "detachFromTarget",
- "description": "Detaches from the target with given id.",
+ "description": "Detaches from the session with given id.",
"parameters": [
- { "name": "targetId", "$ref": "TargetID" }
+ { "name": "sessionId", "$ref": "TargetID" }
caseq 2017/06/27 18:29:30 s/TargetID/SessionID/
]
},
{
@@ -3712,22 +3716,23 @@
"name": "attachedToTarget",
"description": "Issued when attached to target because of auto-attach or <code>attachToTarget</code> command.",
"parameters": [
+ { "name": "sessionId", "$ref": "SessionID", "description": "Id assigned to the session for future communication." },
{ "name": "targetInfo", "$ref": "TargetInfo" },
{ "name": "waitingForDebugger", "type": "boolean" }
]
},
{
"name": "detachedFromTarget",
- "description": "Issued when detached from target for any reason (including <code>detachFromTarget</code> command).",
+ "description": "Issued when detached from session for any reason (including <code>detachFromTarget</code> command).",
"parameters": [
- { "name": "targetId", "$ref": "TargetID" }
+ { "name": "sessionId", "$ref": "SessionID" }
]
},
{
"name": "receivedMessageFromTarget",
- "description": "Notifies about new protocol message from attached target.",
+ "description": "Notifies about a new protocol message from the session (as reported in <code>attachedToTarget</code> event).",
"parameters": [
- { "name": "targetId", "$ref": "TargetID" },
+ { "name": "sessionId", "$ref": "SessionID" },
{ "name": "message", "type": "string" }
]
}

Powered by Google App Engine
This is Rietveld 408576698