Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2951913002: [DevTools] Support multiple sessions in Target domain (Closed)
Patch Set: simplify Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index addd4e13900167f5516e6146f6aae9d67df9b536..22ed0397bcfdf169c77e59c56f1872c84db01ea0 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1662,6 +1662,8 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
command_params->SetString("targetId", attached_id);
SendCommand("Target.attachToTarget", std::move(command_params), true);
params = WaitForNotification("Target.attachedToTarget", true);
+ std::string session_id;
+ EXPECT_TRUE(params->GetString("sessionId", &session_id));
EXPECT_TRUE(params->GetString("targetInfo.targetId", &temp));
EXPECT_EQ(attached_id, temp);
EXPECT_TRUE(notifications_.empty());
@@ -1672,11 +1674,11 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, TargetDiscovery) {
EXPECT_TRUE(notifications_.empty());
command_params.reset(new base::DictionaryValue());
- command_params->SetString("targetId", attached_id);
+ command_params->SetString("sessionId", session_id);
SendCommand("Target.detachFromTarget", std::move(command_params), true);
params = WaitForNotification("Target.detachedFromTarget", true);
- EXPECT_TRUE(params->GetString("targetId", &temp));
- EXPECT_EQ(attached_id, temp);
+ EXPECT_TRUE(params->GetString("sessionId", &temp));
+ EXPECT_EQ(session_id, temp);
EXPECT_TRUE(notifications_.empty());
}
@@ -1742,6 +1744,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsProtocolTest, TargetNoDiscovery) {
command_params->SetBoolean("value", true);
SendCommand("Target.setAttachToFrames", std::move(command_params), false);
params = WaitForNotification("Target.attachedToTarget", true);
+ std::string session_id;
+ EXPECT_TRUE(params->GetString("sessionId", &session_id));
EXPECT_TRUE(params->GetString("targetInfo.targetId", &target_id));
EXPECT_TRUE(params->GetString("targetInfo.type", &temp));
EXPECT_EQ("iframe", temp);
@@ -1751,12 +1755,13 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsProtocolTest, TargetNoDiscovery) {
GURL http_url(embedded_test_server()->GetURL("/title1.html"));
NavigateFrameToURL(child, http_url);
params = WaitForNotification("Target.detachedFromTarget", true);
- EXPECT_TRUE(params->GetString("targetId", &temp));
- EXPECT_EQ(target_id, temp);
+ EXPECT_TRUE(params->GetString("sessionId", &temp));
+ EXPECT_EQ(session_id, temp);
// Navigate back to cross-site iframe.
NavigateFrameToURL(root->child_at(0), cross_site_url);
params = WaitForNotification("Target.attachedToTarget", true);
+ EXPECT_TRUE(params->GetString("sessionId", &session_id));
EXPECT_TRUE(params->GetString("targetInfo.targetId", &target_id));
EXPECT_TRUE(params->GetString("targetInfo.type", &temp));
EXPECT_EQ("iframe", temp);
@@ -1767,8 +1772,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsProtocolTest, TargetNoDiscovery) {
command_params->SetBoolean("waitForDebuggerOnStart", false);
SendCommand("Target.setAutoAttach", std::move(command_params), false);
params = WaitForNotification("Target.detachedFromTarget", true);
- EXPECT_TRUE(params->GetString("targetId", &temp));
- EXPECT_EQ(target_id, temp);
+ EXPECT_TRUE(params->GetString("sessionId", &temp));
+ EXPECT_EQ(session_id, temp);
}
IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, SetAndGetCookies) {

Powered by Google App Engine
This is Rietveld 408576698