Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: .. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index 0860681fc0609e3cd7c8c200d1f83bf9e697699b..6e30457773721f1ea9e1be761e7e9800b3b971e1 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -56,6 +56,7 @@ class MediaControlTextTrackListElement;
class MediaControlTimelineElement;
class MediaControlToggleClosedCaptionsButtonElement;
class MediaControlVolumeSliderElement;
+class MediaDownloadInProductHelpManager;
class ShadowRoot;
// Default implementation of the core/ MediaControls interface used by
@@ -116,6 +117,11 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void EndScrubbing();
void UpdateCurrentTimeDisplay();
+ // Methods used for Download In-product help.
+ const MediaControlDownloadButtonElement& DownloadButton() const;
+ void DidDismissDownloadInProductHelp();
+ MediaDownloadInProductHelpManager* DownloadInProductHelp();
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -134,6 +140,7 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
friend class MediaControlsOrientationLockAndRotateToFullscreenDelegateTest;
friend class MediaControlsRotateToFullscreenDelegateTest;
friend class MediaControlsImplTest;
+ friend class MediaControlsImplInProductHelpTest;
// Need to be members of MediaControls for private member access.
class BatchedControlUpdate;
@@ -165,6 +172,7 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
bool ShouldHideMediaControls(unsigned behavior_flags = 0) const;
void HideMediaControlsTimerFired(TimerBase*);
+ void StartHideMediaControlsIfNecessary();
void StartHideMediaControlsTimer();
void StopHideMediaControlsTimer();
void ResetHideMediaControlsTimer();
@@ -251,6 +259,8 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
IntSize size_;
bool keep_showing_until_timer_fires_ : 1;
+
+ Member<MediaDownloadInProductHelpManager> download_iph_manager_;
};
DEFINE_ELEMENT_TYPE_CASTS(MediaControlsImpl, IsMediaControls());

Powered by Google App Engine
This is Rietveld 408576698