Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: components/feature_engagement/public/feature_list.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: .. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_ 5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_
6 #define COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_ 6 #define COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature. 45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature.
46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy"); 46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy");
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail"); 48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview"); 49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview");
50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome"); 50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage"); 51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature, 52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature,
53 "IPH_DownloadPageScreenshot"); 53 "IPH_DownloadPageScreenshot");
54 DEFINE_VARIATION_PARAM(kIPHChromeHomeExpandFeature, "IPH_ChromeHomeExpand"); 54 DEFINE_VARIATION_PARAM(kIPHChromeHomeExpandFeature, "IPH_ChromeHomeExpand");
55 DEFINE_VARIATION_PARAM(kIPHMediaDownloadFeature, "IPH_MediaDownload");
55 #endif // defined(OS_ANDROID) 56 #endif // defined(OS_ANDROID)
56 #if defined(OS_WIN) || defined(OS_LINUX) 57 #if defined(OS_WIN) || defined(OS_LINUX)
57 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow"); 58 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow");
58 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab"); 59 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab");
59 #endif // defined(OS_WIN) || defined(OS_LINUX) 60 #endif // defined(OS_WIN) || defined(OS_LINUX)
60 #if defined(OS_IOS) 61 #if defined(OS_IOS)
61 DEFINE_VARIATION_PARAM(kIPHNewTabTipFeature, "IPH_NewTabTip"); 62 DEFINE_VARIATION_PARAM(kIPHNewTabTipFeature, "IPH_NewTabTip");
62 DEFINE_VARIATION_PARAM(kIPHNewIncognitoTabTipFeature, "IPH_NewIncognitoTabTip"); 63 DEFINE_VARIATION_PARAM(kIPHNewIncognitoTabTipFeature, "IPH_NewIncognitoTabTip");
63 DEFINE_VARIATION_PARAM(kIPHBadgedReadingListFeature, "IPH_BadgedReadingList"); 64 DEFINE_VARIATION_PARAM(kIPHBadgedReadingListFeature, "IPH_BadgedReadingList");
64 #endif // defined(OS_IOS) 65 #endif // defined(OS_IOS)
65 66
66 } // namespace 67 } // namespace
67 68
68 // Defines the array of which features should be listed in the chrome://flags 69 // Defines the array of which features should be listed in the chrome://flags
69 // UI to be able to select them alone for demo-mode. The features listed here 70 // UI to be able to select them alone for demo-mode. The features listed here
70 // are possible to enable on their own in demo mode. 71 // are possible to enable on their own in demo mode.
71 constexpr flags_ui::FeatureEntry::FeatureVariation 72 constexpr flags_ui::FeatureEntry::FeatureVariation
72 kIPHDemoModeChoiceVariations[] = { 73 kIPHDemoModeChoiceVariations[] = {
73 #if defined(OS_ANDROID) 74 #if defined(OS_ANDROID)
74 VARIATION_ENTRY(kIPHDataSaverDetailFeature), 75 VARIATION_ENTRY(kIPHDataSaverDetailFeature),
75 VARIATION_ENTRY(kIPHDataSaverPreviewFeature), 76 VARIATION_ENTRY(kIPHDataSaverPreviewFeature),
76 VARIATION_ENTRY(kIPHDownloadHomeFeature), 77 VARIATION_ENTRY(kIPHDownloadHomeFeature),
77 VARIATION_ENTRY(kIPHDownloadPageFeature), 78 VARIATION_ENTRY(kIPHDownloadPageFeature),
78 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature), 79 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature),
79 VARIATION_ENTRY(kIPHChromeHomeExpandFeature), 80 VARIATION_ENTRY(kIPHChromeHomeExpandFeature),
81 VARIATION_ENTRY(kIPHMediaDownloadFeature),
80 #elif defined(OS_WIN) || defined(OS_LINUX) 82 #elif defined(OS_WIN) || defined(OS_LINUX)
81 VARIATION_ENTRY(kIPHIncognitoWindowFeature), 83 VARIATION_ENTRY(kIPHIncognitoWindowFeature),
82 VARIATION_ENTRY(kIPHNewTabFeature), 84 VARIATION_ENTRY(kIPHNewTabFeature),
83 #elif defined(OS_IOS) 85 #elif defined(OS_IOS)
84 VARIATION_ENTRY(kIPHNewTabTipFeature), 86 VARIATION_ENTRY(kIPHNewTabTipFeature),
85 VARIATION_ENTRY(kIPHNewIncognitoTabTipFeature), 87 VARIATION_ENTRY(kIPHNewIncognitoTabTipFeature),
86 VARIATION_ENTRY(kIPHBadgedReadingListFeature), 88 VARIATION_ENTRY(kIPHBadgedReadingListFeature),
87 #else 89 #else
88 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array. 90 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array.
89 #endif 91 #endif
90 }; 92 };
91 93
92 #undef DEFINE_VARIATION_PARAM 94 #undef DEFINE_VARIATION_PARAM
93 #undef VARIATION_ENTRY 95 #undef VARIATION_ENTRY
94 96
95 // Returns all the features that are in use for engagement tracking. 97 // Returns all the features that are in use for engagement tracking.
96 FeatureVector GetAllFeatures(); 98 FeatureVector GetAllFeatures();
97 99
98 } // namespace feature_engagement 100 } // namespace feature_engagement
99 101
100 #endif // COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_ 102 #endif // COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_FEATURE_LIST_H_
OLDNEW
« no previous file with comments | « components/feature_engagement/public/feature_constants.cc ('k') | components/feature_engagement/public/feature_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698