Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: components/feature_engagement/public/feature_list.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: .. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /// Copyright 2017 The Chromium Authors. All rights reserved. 1 /// Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/feature_engagement/public/feature_list.h" 5 #include "components/feature_engagement/public/feature_list.h"
6 6
7 #include "components/feature_engagement/public/feature_constants.h" 7 #include "components/feature_engagement/public/feature_constants.h"
8 8
9 namespace feature_engagement { 9 namespace feature_engagement {
10 10
11 namespace { 11 namespace {
12 // Whenever a feature is added to |kAllFeatures|, it should also be added as 12 // Whenever a feature is added to |kAllFeatures|, it should also be added as
13 // DEFINE_VARIATION_PARAM in the header, and also added to the 13 // DEFINE_VARIATION_PARAM in the header, and also added to the
14 // |kIPHDemoModeChoiceVariations| array. 14 // |kIPHDemoModeChoiceVariations| array.
15 const base::Feature* const kAllFeatures[] = { 15 const base::Feature* const kAllFeatures[] = {
16 &kIPHDummyFeature, // Ensures non-empty array for all platforms. 16 &kIPHDummyFeature, // Ensures non-empty array for all platforms.
17 #if defined(OS_ANDROID) 17 #if defined(OS_ANDROID)
18 &kIPHDataSaverDetailFeature, 18 &kIPHDataSaverDetailFeature,
19 &kIPHDataSaverPreviewFeature, 19 &kIPHDataSaverPreviewFeature,
20 &kIPHDownloadHomeFeature, 20 &kIPHDownloadHomeFeature,
21 &kIPHDownloadPageFeature, 21 &kIPHDownloadPageFeature,
22 &kIPHDownloadPageScreenshotFeature, 22 &kIPHDownloadPageScreenshotFeature,
23 &kIPHChromeHomeExpandFeature, 23 &kIPHChromeHomeExpandFeature,
24 &kIPHMediaDownloadFeature,
24 #endif // defined(OS_ANDROID) 25 #endif // defined(OS_ANDROID)
25 #if defined(OS_WIN) || defined(OS_LINUX) 26 #if defined(OS_WIN) || defined(OS_LINUX)
26 &kIPHIncognitoWindowFeature, 27 &kIPHIncognitoWindowFeature,
27 &kIPHNewTabFeature, 28 &kIPHNewTabFeature,
28 #endif // defined(OS_WIN) || defined(OS_LINUX) 29 #endif // defined(OS_WIN) || defined(OS_LINUX)
29 #if defined(OS_IOS) 30 #if defined(OS_IOS)
30 &kIPHNewTabTipFeature, 31 &kIPHNewTabTipFeature,
31 &kIPHNewIncognitoTabTipFeature, 32 &kIPHNewIncognitoTabTipFeature,
32 &kIPHBadgedReadingListFeature, 33 &kIPHBadgedReadingListFeature,
33 #endif // defined(OS_IOS) 34 #endif // defined(OS_IOS)
34 }; 35 };
35 } // namespace 36 } // namespace
36 37
37 const char kIPHDemoModeFeatureChoiceParam[] = "chosen_feature"; 38 const char kIPHDemoModeFeatureChoiceParam[] = "chosen_feature";
38 39
39 std::vector<const base::Feature*> GetAllFeatures() { 40 std::vector<const base::Feature*> GetAllFeatures() {
40 return std::vector<const base::Feature*>( 41 return std::vector<const base::Feature*>(
41 kAllFeatures, kAllFeatures + arraysize(kAllFeatures)); 42 kAllFeatures, kAllFeatures + arraysize(kAllFeatures));
42 } 43 }
43 44
44 } // namespace feature_engagement 45 } // namespace feature_engagement
OLDNEW
« no previous file with comments | « components/feature_engagement/public/feature_list.h ('k') | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698