third_party/WebKit/Source/core/paint/ScrollbarManager.h - Issue 2942163002: [Refactor] Moved scrollbar creation and deletion to ScrollbarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ScrollbarManager.h

Issue 2942163002: [Refactor] Moved scrollbar creation and deletion to ScrollbarManager (Closed)

Patch Set: bokan and skobes comments addressed Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ScrollbarManager.h

diff --git a/third_party/WebKit/Source/core/paint/ScrollbarManager.h b/third_party/WebKit/Source/core/paint/ScrollbarManager.h

index 09dac5b1349693cf1ad31b006eeb7abf0c6d846d..01f2dcd0977ff9ca5920f676f86b4b3d0f6c0775 100644

--- a/third_party/WebKit/Source/core/paint/ScrollbarManager.h

+++ b/third_party/WebKit/Source/core/paint/ScrollbarManager.h

@@ -34,11 +34,9 @@ class CORE_EXPORT ScrollbarManager {

DECLARE_VIRTUAL_TRACE();

- protected:

- // TODO(ymalik): This can be made non-virtual since there's a lot of

- // common code in subclasses.

- virtual Scrollbar* CreateScrollbar(ScrollbarOrientation) = 0;

- virtual void DestroyScrollbar(ScrollbarOrientation) = 0;

+ Scrollbar* CreateScrollbar(ScrollbarOrientation);

+ void DestroyScrollbar(ScrollbarOrientation);

protected:

Member<ScrollableArea> scrollable_area_;