Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: content/browser/service_worker/service_worker_client_utils.h

Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time (Closed)
Patch Set: Address shimazu's comments #31 and fix the test failure Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_client_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_client_utils.h
diff --git a/content/browser/service_worker/service_worker_client_utils.h b/content/browser/service_worker/service_worker_client_utils.h
index be46f6c13e78b3ce44d5ece4aac6f074d98e4f60..5c80db2d97e12c02227de3d31ffac47850155937 100644
--- a/content/browser/service_worker/service_worker_client_utils.h
+++ b/content/browser/service_worker/service_worker_client_utils.h
@@ -30,7 +30,8 @@ using NavigationCallback =
using ClientCallback =
base::Callback<void(const ServiceWorkerClientInfo& client_info)>;
using ServiceWorkerClients = std::vector<ServiceWorkerClientInfo>;
-using ClientsCallback = base::Callback<void(ServiceWorkerClients* clients)>;
+using ClientsCallback =
+ base::Callback<void(std::unique_ptr<ServiceWorkerClients> clients)>;
// Focuses the window client associated with |provider_host|. |callback| is
// called with the client information on completion.
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_client_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698