Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2904723002: Change ContentData::operator== to iterate through whole list. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ContentData::operator== to iterate through whole list. ContentData is a class that has a linked list structure. To compare two ContentDatas, ComputedStyle iterates through the two lists and checks that each element is equal using operator==, which calls through to ContentData::Equals. Instead of leaving the iteration logic in ComputedStyle, this patch moves it to operator==, so that operator== iterates through the two linked lists and compares each element using ContentData::Equals. This allows ComputedStyle to just use operator== on ContentData. This transformation causes no behavioural changes as ContentData's operator== was only used by ComputedStyle. BUG=628043 Review-Url: https://codereview.chromium.org/2904723002 Cr-Commit-Position: refs/heads/master@{#474408} Committed: https://chromium.googlesource.com/chromium/src/+/e452a38ed13a4b9c472196221494d228a8be7f30

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M third_party/WebKit/Source/core/style/ContentData.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 1 chunk +1 line, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-23 23:02:35 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-24 01:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904723002/20001
3 years, 7 months ago (2017-05-24 20:37:53 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:44:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e452a38ed13a4b9c472196221494...

Powered by Google App Engine
This is Rietveld 408576698