Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2902923002: Roll chromium_revision fc674bec51..cca67d31f4 (473937:474153) (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision fc674bec51..cca67d31f4 (473937:474153) Memcheck suppression stacks changed slightly due to the googletest roll so a few suppressions needed to be updated. Change log: https://chromium.googlesource.com/chromium/src/+log/fc674bec51..cca67d31f4 Full diff: https://chromium.googlesource.com/chromium/src/+/fc674bec51..cca67d31f4 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/14fe060b4d..414d17a2ac * src/build: https://chromium.googlesource.com/chromium/src/build/+log/b19d8a0c0e..5488ca8df8 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/4378a2bccb..e344c3eca3 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/34532746b5..2393ca4149 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5530bd0f35..f336aafa2c * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08a6e0ac16..f136f48001 * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/8c7f93feda..42bc671f47 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e9c26b8d46..06b0b52a2c DEPS diff: https://chromium.googlesource.com/chromium/src/+/fc674bec51..cca67d31f4/DEPS No update to Clang. TBR= BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2902923002 Cr-Commit-Position: refs/heads/master@{#18251} Committed: https://chromium.googlesource.com/external/webrtc/+/d5115e0cacac492ff837bf8aeb26ce13b9b39f47

Patch Set 1 #

Patch Set 2 : Generalized some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M DEPS View 6 chunks +9 lines, -9 lines 0 comments Download
M tools_webrtc/valgrind/memcheck/suppressions.txt View 1 4 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
kjellander_webrtc
Only running failed tryjobs of https://codereview.webrtc.org/2903763002/
3 years, 7 months ago (2017-05-24 06:04:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2902923002/20001
3 years, 7 months ago (2017-05-24 07:55:12 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 07:57:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d5115e0cacac492ff837bf8ae...

Powered by Google App Engine
This is Rietveld 408576698