Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: content/browser/appcache/appcache_url_request_job.h

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_url_request_job.h
diff --git a/content/browser/appcache/appcache_url_request_job.h b/content/browser/appcache/appcache_url_request_job.h
index 56b3cfa39c2b197513239ee6213de92d83f3f543..f4f23a74301b57893cf5952dc5b9348c9bdfa6d2 100644
--- a/content/browser/appcache/appcache_url_request_job.h
+++ b/content/browser/appcache/appcache_url_request_job.h
@@ -44,11 +44,6 @@ class CONTENT_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
// AppCacheJob overrides.
void Kill() override;
bool IsStarted() const override;
- bool IsWaiting() const override;
- bool IsDeliveringAppCacheResponse() const override;
- bool IsDeliveringNetworkResponse() const override;
- bool IsDeliveringErrorResponse() const override;
- bool IsCacheEntryNotFound() const override;
void DeliverAppCachedResponse(const GURL& manifest_url,
int64_t cache_id,
const AppCacheEntry& entry,
@@ -83,13 +78,6 @@ class CONTENT_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
bool is_main_resource,
const OnPrepareToRestartCallback& restart_callback_);
- enum DeliveryType {
- AWAITING_DELIVERY_ORDERS,
- APPCACHED_DELIVERY,
- NETWORK_DELIVERY,
- ERROR_DELIVERY
- };
-
// Returns true if one of the Deliver methods has been called.
bool has_delivery_orders() const { return !IsWaiting(); }
@@ -140,13 +128,11 @@ class CONTENT_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
base::TimeTicks start_time_tick_;
bool has_been_started_;
bool has_been_killed_;
- DeliveryType delivery_type_;
GURL manifest_url_;
int64_t cache_id_;
AppCacheEntry entry_;
bool is_fallback_;
bool is_main_resource_; // Used for histogram logging.
- bool cache_entry_not_found_;
scoped_refptr<AppCacheResponseInfo> info_;
scoped_refptr<net::GrowableIOBuffer> handler_source_buffer_;
std::unique_ptr<AppCacheResponseReader> handler_source_reader_;
« no previous file with comments | « content/browser/appcache/appcache_url_loader_request.cc ('k') | content/browser/appcache/appcache_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698