Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: content/browser/appcache/appcache_url_loader_request.h

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_url_loader_request.h
diff --git a/content/browser/appcache/appcache_url_loader_request.h b/content/browser/appcache/appcache_url_loader_request.h
index 13581f15015a9ed1c53015646a4250d4648677a1..97e3f773fdb9305f8464cb448e9ef338f83c85ea 100644
--- a/content/browser/appcache/appcache_url_loader_request.h
+++ b/content/browser/appcache/appcache_url_loader_request.h
@@ -17,7 +17,7 @@ class CONTENT_EXPORT AppCacheURLLoaderRequest : public AppCacheRequest {
// Factory function to create an instance of the AppCacheResourceRequest
// class.
static std::unique_ptr<AppCacheURLLoaderRequest> Create(
- std::unique_ptr<ResourceRequest> request);
+ const ResourceRequest& request);
~AppCacheURLLoaderRequest() override;
@@ -38,14 +38,13 @@ class CONTENT_EXPORT AppCacheURLLoaderRequest : public AppCacheRequest {
bool IsError() const override;
int GetResponseCode() const override;
std::string GetResponseHeaderByName(const std::string& name) const override;
-
ResourceRequest* GetResourceRequest() override;
protected:
- explicit AppCacheURLLoaderRequest(std::unique_ptr<ResourceRequest> request);
+ explicit AppCacheURLLoaderRequest(const ResourceRequest& request);
private:
- std::unique_ptr<ResourceRequest> request_;
+ ResourceRequest request_;
DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoaderRequest);
};
« no previous file with comments | « content/browser/appcache/appcache_url_loader_job.cc ('k') | content/browser/appcache/appcache_url_loader_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698