Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: content/browser/appcache/appcache_job.h

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/appcache/appcache_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_job.h
diff --git a/content/browser/appcache/appcache_job.h b/content/browser/appcache/appcache_job.h
index e43bb121c52b05caffe48c863422d561e72a2ce4..c18c772eb8a5ea5ba60756215ac147f7be8e5f71 100644
--- a/content/browser/appcache/appcache_job.h
+++ b/content/browser/appcache/appcache_job.h
@@ -35,6 +35,13 @@ class URLRequestJob;
// of the AppCache code.
class CONTENT_EXPORT AppCacheJob : public base::SupportsWeakPtr<AppCacheJob> {
public:
+ enum DeliveryType {
+ AWAITING_DELIVERY_ORDERS,
+ APPCACHED_DELIVERY,
+ NETWORK_DELIVERY,
+ ERROR_DELIVERY
+ };
+
// Callback that will be invoked before the request is restarted. The caller
// can use this opportunity to grab state from the job to determine how it
// should behave when the request is restarted.
@@ -63,19 +70,19 @@ class CONTENT_EXPORT AppCacheJob : public base::SupportsWeakPtr<AppCacheJob> {
virtual bool IsStarted() const = 0;
// Returns true if the job is waiting for instructions.
- virtual bool IsWaiting() const = 0;
+ virtual bool IsWaiting() const;
// Returns true if the job is delivering a response from the cache.
- virtual bool IsDeliveringAppCacheResponse() const = 0;
+ virtual bool IsDeliveringAppCacheResponse() const;
// Returns true if the job is delivering a response from the network.
- virtual bool IsDeliveringNetworkResponse() const = 0;
+ virtual bool IsDeliveringNetworkResponse() const;
// Returns true if the job is delivering an error response.
- virtual bool IsDeliveringErrorResponse() const = 0;
+ virtual bool IsDeliveringErrorResponse() const;
// Returns true if the cache entry was not found in the cache.
- virtual bool IsCacheEntryNotFound() const = 0;
+ virtual bool IsCacheEntryNotFound() const;
// Informs the job of what response it should deliver. Only one of these
// methods should be called, and only once per job. A job will sit idle and
@@ -111,6 +118,12 @@ class CONTENT_EXPORT AppCacheJob : public base::SupportsWeakPtr<AppCacheJob> {
SEQUENCE_CHECKER(sequence_checker_);
+ // Set to true if the AppCache entry is not found.
+ bool cache_entry_not_found_;
+
+ // The jobs delivery status.
+ DeliveryType delivery_type_;
+
base::WeakPtrFactory<AppCacheJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(AppCacheJob);
« no previous file with comments | « no previous file | content/browser/appcache/appcache_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698