Remove entry from map_ of ClipboardMap when jstr is null or empty

Remove entry from map_ of ClipboardMap when jstr is null or empty

A ClipData in Android side could have more than one entry in
ClipboardMap, so if onPrimaryClipChanged happened, we need to
remove invalidated entries from map_ of ClipboardMap.

For instance, if we have an HTML ClipData, we will have two
entries with key |kPlainTextFormat| and |kHTMLFormat| in
ClipboardMap. If the following step is to copy plain text, only
|kPlainTextFormat| entry got updated. However, on the paste side,
it will ask HTML text first but HTML text is not valid anymore.

BUG=725427
Review-Url: https://codereview.chromium.org/2901143002
Cr-Commit-Position: refs/heads/master@{#474163}
Committed: https://chromium.googlesource.com/chromium/src/+/40b3e614e6305fdbe0b925307790ececaf3891ea

[Shimi Zhang, 2017-05-23 22:10:47]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 22:12:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-23 22:13:46]

ctzsm@chromium.org changed reviewers:
+ dcheng@chromium.org

[Shimi Zhang, 2017-05-23 22:13:46]

dcheng@, PTAL.

Since this was removed by mpearson@, so ccing.

Thanks!

[dcheng, 2017-05-23 23:13:24]

On 2017/05/23 22:13:46, Shimi Zhang wrote:
> dcheng@, PTAL.
> 
> Since this was removed by mpearson@, so ccing.
> 
> Thanks!

Should AddMapEntry just clear the entry from the map if the input jstring is
null?

[Shimi Zhang, 2017-05-24 00:21:49]

On 2017/05/23 23:13:24, dcheng wrote:
> On 2017/05/23 22:13:46, Shimi Zhang wrote:
> > dcheng@, PTAL.
> > 
> > Since this was removed by mpearson@, so ccing.
> > 
> > Thanks!
> 
> Should AddMapEntry just clear the entry from the map if the input jstring is
> null?

Neat! That should also work, thanks!

[Shimi Zhang, 2017-05-24 00:59:40]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:00:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-24 01:03:25]

Description was changed from

==========
Invalidate map_ of ClipboardMap when UpdateFromAndroidClipboard

A ClipData in Android side could have more than one entry in
ClipboardMap, so if onPrimaryClipChanged happened, we need to
Invalidate map_ inside of ClipboardMap.

For instance, if we have an HTML ClipData, we will have two
entries with key |kPlainTextFormat| and |kHTMLFormat| in
ClipboardMap. If the following step is to copy plain text, only
|kPlainTextFormat| entry got updated. However, on the paste side,
it will ask HTML text first but HTML text is not valid anymore.

BUG=725427
==========

to

==========
Remove entry from map_ of ClipboardMap when jstr is null or empty

A ClipData in Android side could have more than one entry in
ClipboardMap, so if onPrimaryClipChanged happened, we need to
remove invalidated entries from map_ of ClipboardMap.

For instance, if we have an HTML ClipData, we will have two
entries with key |kPlainTextFormat| and |kHTMLFormat| in
ClipboardMap. If the following step is to copy plain text, only
|kPlainTextFormat| entry got updated. However, on the paste side,
it will ask HTML text first but HTML text is not valid anymore.

BUG=725427
==========

[Shimi Zhang, 2017-05-24 01:03:52]

On 2017/05/24 00:21:49, Shimi Zhang wrote:
> On 2017/05/23 23:13:24, dcheng wrote:
> > On 2017/05/23 22:13:46, Shimi Zhang wrote:
> > > dcheng@, PTAL.
> > > 
> > > Since this was removed by mpearson@, so ccing.
> > > 
> > > Thanks!
> > 
> > Should AddMapEntry just clear the entry from the map if the input jstring is
> > null?
> 
> Neat! That should also work, thanks!

dcheng@, updated, PTAL.

[dcheng, 2017-05-24 01:48:29]

LGTM, assuming manual testing verified this fix

[commit-bot: I haz the power, 2017-05-24 04:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:05:18]

Dry run: This issue passed the CQ dry run.

[Shimi Zhang, 2017-05-24 04:42:13]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:42:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:48:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495600933013280,
"parent_rev": "3bb29f17b7d6f9fdd75ff25bad2aec664b627161", "commit_rev":
"40b3e614e6305fdbe0b925307790ececaf3891ea"}

[commit-bot: I haz the power, 2017-05-24 04:48:30]

Description was changed from

==========
Remove entry from map_ of ClipboardMap when jstr is null or empty

A ClipData in Android side could have more than one entry in
ClipboardMap, so if onPrimaryClipChanged happened, we need to
remove invalidated entries from map_ of ClipboardMap.

For instance, if we have an HTML ClipData, we will have two
entries with key |kPlainTextFormat| and |kHTMLFormat| in
ClipboardMap. If the following step is to copy plain text, only
|kPlainTextFormat| entry got updated. However, on the paste side,
it will ask HTML text first but HTML text is not valid anymore.

BUG=725427
==========

to

==========
Remove entry from map_ of ClipboardMap when jstr is null or empty

A ClipData in Android side could have more than one entry in
ClipboardMap, so if onPrimaryClipChanged happened, we need to
remove invalidated entries from map_ of ClipboardMap.

For instance, if we have an HTML ClipData, we will have two
entries with key |kPlainTextFormat| and |kHTMLFormat| in
ClipboardMap. If the following step is to copy plain text, only
|kPlainTextFormat| entry got updated. However, on the paste side,
it will ask HTML text first but HTML text is not valid anymore.

BUG=725427

Review-Url: https://codereview.chromium.org/2901143002
Cr-Commit-Position: refs/heads/master@{#474163}
Committed:
https://chromium.googlesource.com/chromium/src/+/40b3e614e6305fdbe0b925307790...
==========

[commit-bot: I haz the power, 2017-05-24 04:48:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40b3e614e6305fdbe0b925307790...