Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2900183003: [Home] Close the bottom sheet when the tab model is switched (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Close the bottom sheet when the tab model is switched This ensures the bottom sheet is properly closed when the incognito notification closes all incognito tabs. BUG=725413 Review-Url: https://codereview.chromium.org/2900183003 Cr-Commit-Position: refs/heads/master@{#474169} Committed: https://chromium.googlesource.com/chromium/src/+/bfc4a9910e0e509249b22a1fb5a86326ddfb88d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-23 23:29:34 UTC) #2
mdjones
lgtm
3 years, 7 months ago (2017-05-23 23:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900183003/1
3 years, 7 months ago (2017-05-23 23:42:00 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 05:07:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfc4a9910e0e509249b22a1fb5a8...

Powered by Google App Engine
This is Rietveld 408576698