Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2899233002: Make VisibleUnits::ComputeTextFloat return unified FloatRect. (Closed)

Created:
3 years, 7 months ago by yoichio
Modified:
3 years, 7 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisibleUnits::ComputeTextFloat return unified FloatRect. Since only usage of LayoutObject::AbsoluteBoundingBoxRectForRange() uses it as unified FloatRect, lets unify it in VisibleUnit(fortunately we already have unification in it). RangeTest: : Review-Url: https://codereview.chromium.org/2899233002 Cr-Commit-Position: refs/heads/master@{#474219} Committed: https://chromium.googlesource.com/chromium/src/+/5ed8ccaec77a06d6610d40e1ea7aefa8e364eb2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/RangeTest.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yoichio
3 years, 7 months ago (2017-05-24 05:45:45 UTC) #5
yosin_UTC9
lgtm +tkent@ for trivial changes in core/dom and core/layout
3 years, 7 months ago (2017-05-24 08:41:35 UTC) #9
tkent
lgtm
3 years, 7 months ago (2017-05-24 08:42:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899233002/1
3 years, 7 months ago (2017-05-24 09:01:25 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 09:06:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ed8ccaec77a06d6610d40e1ea7a...

Powered by Google App Engine
This is Rietveld 408576698