third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html - Issue 2899163002: DevTools: Promisify Runtime domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html

Issue 2899163002: DevTools: Promisify Runtime domain (Closed)

Patch Set: addressing comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html b/third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html

index 71ae9ef45311734e33ff5a14929b859f6e511e67..c3ce2fa5f9230333e4c4301591db5be6c50492d1 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html

@@ -12,12 +12,12 @@ function doit()

function test()

{

- InspectorTest.RuntimeAgent.evaluate("window", "console", false, evalCallback);

+ InspectorTest.RuntimeAgent.evaluate("window", "console", false).then(evalCallback);

- function evalCallback(error, result)

+ function evalCallback(result)

{

- if (error) {

- testController.notifyDone("Exception:" + error);

+ if (!result) {

+ testController.notifyDone("Exception");

return;

}

if (result.type === "error")