Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2899053006:
Add operator== to CSSTransitionData. (Closed)
|
Created:
3 years, 7 months ago by shend Modified:
3 years, 7 months ago Reviewers:
alancutter (OOO until 2018) CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd operator== to CSSTransitionData.
This patch adds an operator== to CSSTransitionData that is used by
ComputedStyle to check equality for style resolve. Note this is
different to a full, memberwise equality.
BUG=628043
Review-Url: https://codereview.chromium.org/2899053006
Cr-Commit-Position: refs/heads/master@{#474551}
Committed: https://chromium.googlesource.com/chromium/src/+/b2f8ce3799042b20855abda1cf3a62cdd8180f45
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Messages
Total messages: 26 (20 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
shend@chromium.org changed reviewers: + alancutter@chromium.org
Hi Alan, PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2899053006/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2899053006/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495680993832410,
"parent_rev": "a759779ea423073c8e45f598a191e9878c17724c", "commit_rev":
"b2f8ce3799042b20855abda1cf3a62cdd8180f45"}
Message was sent while issue was closed.
Description was changed from ========== Add operator== to CSSTransitionData. This patch adds an operator== to CSSTransitionData that is used by ComputedStyle to check equality for style resolve. Note this is different to a full, memberwise equality. BUG=628043 ========== to ========== Add operator== to CSSTransitionData. This patch adds an operator== to CSSTransitionData that is used by ComputedStyle to check equality for style resolve. Note this is different to a full, memberwise equality. BUG=628043 Review-Url: https://codereview.chromium.org/2899053006 Cr-Commit-Position: refs/heads/master@{#474551} Committed: https://chromium.googlesource.com/chromium/src/+/b2f8ce3799042b20855abda1cf3a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b2f8ce3799042b20855abda1cf3a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
