Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 2897123002: [Fuchsia] Fix test image creation (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M BUILD.gn View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 7 months ago (2017-05-23 18:07:45 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2897123002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2897123002/diff/1/BUILD.gn#newcode123 BUILD.gn:123: # 'dart_build_fuchsia_test_image' because building the image is slow. ...
3 years, 7 months ago (2017-05-23 20:59:04 UTC) #3
zra
Committed patchset #2 (id:20001) manually as 7f16342577d47e408b4cdd59671ba1a36633c7a5 (presubmit successful).
3 years, 7 months ago (2017-05-24 05:15:06 UTC) #5
zra
3 years, 7 months ago (2017-05-24 05:19:23 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2897123002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2897123002/diff/1/BUILD.gn#newcode123
BUILD.gn:123: # 'dart_build_fuchsia_test_image' because building the image is
slow.
On 2017/05/23 20:59:04, rmacnak wrote:
> Remove dead flag.

Done in https://codereview.chromium.org/2902083002/

Powered by Google App Engine
This is Rietveld 408576698