Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: components/favicon/core/large_icon_service.h

Issue 2896803002: [LargeIconService] Make check_seen param optional for fetching (Closed)
Patch Set: Comments on unit-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon/core/large_icon_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/large_icon_service.h
diff --git a/components/favicon/core/large_icon_service.h b/components/favicon/core/large_icon_service.h
index d07888a044cf785f55589040f29783effef229d8..b25ab3e3018d0bca625db601f05aae198a577bcf 100644
--- a/components/favicon/core/large_icon_service.h
+++ b/components/favicon/core/large_icon_service.h
@@ -75,6 +75,11 @@ class LargeIconService : public KeyedService {
// |desired_size_in_pixel| serves only as a hint to the service, no guarantees
// on the fetched size are provided.
//
+ // Unless you are sure |page_url| is a public URL (known to Google Search),
+ // set |may_page_url_be_private| to true. This slighty increases the chance of
+ // a failure (e.g. if the URL _is_ private) but it makes sure Google servers
+ // do not crawl a private URL as a result of this call.
+ //
// The callback is triggered when the operation finishes, where |success|
// tells whether the fetch actually managed to database a new icon in the
// FaviconService.
@@ -88,6 +93,7 @@ class LargeIconService : public KeyedService {
const GURL& page_url,
int min_source_size_in_pixel,
int desired_size_in_pixel,
+ bool may_page_url_be_private,
const base::Callback<void(bool success)>& callback);
private:
« no previous file with comments | « no previous file | components/favicon/core/large_icon_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698