third_party/WebKit/Source/core/dom/SpaceSplitString.cpp - Issue 2895903002: DOMTokenList: Update serialization algorithm on add()/remove()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

Issue 2895903002: DOMTokenList: Update serialization algorithm on add()/remove() (Closed)

Patch Set: Apply review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

diff --git a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

index 1552345488e9bd02c388a1b34dd5e7db9da1e169..9f4b94c66d95c5e869291bf13f07aec88a277076 100644

--- a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

+++ b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

@@ -116,6 +116,8 @@ void SpaceSplitString::Add(const AtomicString& string) {

EnsureUnique();

if (data_)

data_->Add(string);

+ else

+ data_ = Data::Create(string);

}

bool SpaceSplitString::Remove(const AtomicString& string) {