Replace AnimatableValues with ComputedStyle references for CSS Transitions

Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start-value

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

Design doc:
https://docs.google.com/document/d/1cvuLElVHaeM9YvqxoedcdilPD9MVD4EtfNfl9R_rKbk/edit

BUG=725385
Review-Url: https://codereview.chromium.org/2895283004
Cr-Commit-Position: refs/heads/master@{#474559}
Committed: https://chromium.googlesource.com/chromium/src/+/2bdf1977ad4c41816296f03ddfe9429184b8fd34

[alancutter (OOO until 2018), 2017-05-23 05:13:23]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:13:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-05-23 06:53:58]

Description was changed from

==========
transitionsUseComputedStyles

BUG=
==========

to

==========
Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start...

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

BUG=725385
==========

[alancutter (OOO until 2018), 2017-05-23 06:53:58]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:16:05]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-05-24 01:38:07]

Description was changed from

==========
Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start...

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

BUG=725385
==========

to

==========
Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start...

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

Design doc:
https://docs.google.com/document/d/1cvuLElVHaeM9YvqxoedcdilPD9MVD4EtfNfl9R_rK...

BUG=725385
==========

[Eric Willigers, 2017-05-24 05:43:59]

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:794:
state.cloned_style = ComputedStyle::Clone(state.style);
Why is safe to not always overwrite?

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:881: nullptr,
active_transitions, listed_properties,       *transition_data};
Why the spaces?

[alancutter (OOO until 2018), 2017-05-24 06:34:44]

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:794:
state.cloned_style = ComputedStyle::Clone(state.style);
On 2017/05/24 at 05:43:58, Eric Willigers wrote:
> Why is safe to not always overwrite?

This cloned style is shared between transitions that start at the same time for
the same element.

https://codereview.chromium.org/2895283004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:881: nullptr,
active_transitions, listed_properties,       *transition_data};
On 2017/05/24 at 05:43:58, Eric Willigers wrote:
> Why the spaces?

This is what git cl format does.

[Eric Willigers, 2017-05-24 06:35:10]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:35:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 06:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:35:34]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Eric Willigers, 2017-05-25 03:02:21]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-05-25 03:02:21]

lgtm

[commit-bot: I haz the power, 2017-05-25 03:03:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:13:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495681341516340, "parent_rev":
"22499abf48191c58dd37bffd291157e9a06278a4", "commit_rev":
"2bdf1977ad4c41816296f03ddfe9429184b8fd34"}

[commit-bot: I haz the power, 2017-05-25 05:13:45]

Description was changed from

==========
Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start...

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

Design doc:
https://docs.google.com/document/d/1cvuLElVHaeM9YvqxoedcdilPD9MVD4EtfNfl9R_rK...

BUG=725385
==========

to

==========
Replace AnimatableValues with ComputedStyle references for CSS Transitions

This change replaces AnimatableValues with ComputedStyle references
in our CSS Transition data.
This data is used for detecting and processing reversed transitions,
see spec for further detail:
https://drafts.csswg.org/css-transitions/#transition-reversing-adjusted-start...

By replacing AnimatableValues we remove the dependency on the vast majority
of AnimatableValue types. This will allow us to remove large portions
of the class hierarchy.

Design doc:
https://docs.google.com/document/d/1cvuLElVHaeM9YvqxoedcdilPD9MVD4EtfNfl9R_rK...

BUG=725385

Review-Url: https://codereview.chromium.org/2895283004
Cr-Commit-Position: refs/heads/master@{#474559}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bdf1977ad4c41816296f03ddfe9...
==========

[commit-bot: I haz the power, 2017-05-25 05:13:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bdf1977ad4c41816296f03ddfe9...