Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2894993002: fuchsia: Implement SysInfo::AmountOfPhysicalMemory and NumberOfProcessors (Closed)

Created:
3 years, 7 months ago by scottmg
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : fix rebase #

Patch Set 8 : rebase to origin/master #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
A base/sys_info_fuchsia.cc View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M base/sys_info_posix.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (18 generated)
scottmg
3 years, 7 months ago (2017-05-24 00:06:51 UTC) #7
Lei Zhang
lgtm Have you looked into enabling (parts of) base/sys_info_unittest.cc ?
3 years, 7 months ago (2017-05-24 00:19:08 UTC) #11
scottmg
On 2017/05/24 00:19:08, Lei Zhang wrote: > lgtm > > Have you looked into enabling ...
3 years, 7 months ago (2017-05-24 00:26:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894993002/140001
3 years, 7 months ago (2017-05-24 00:33:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894993002/160001
3 years, 7 months ago (2017-05-24 03:54:16 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 05:56:24 UTC) #24
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/aaa608f0db6a15e4fbe95e535636...

Powered by Google App Engine
This is Rietveld 408576698