Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: components/subresource_filter/core/common/document_subresource_filter.cc

Issue 2894523006: Add instrumentation hooks to mesaure which subresource filter rules are used.
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/core/common/document_subresource_filter.cc
diff --git a/components/subresource_filter/core/common/document_subresource_filter.cc b/components/subresource_filter/core/common/document_subresource_filter.cc
index 3895a3a88f8e5a87741519d51c9a5a1aa772d1b2..e48394da419f08d794e8a27cb3a916f6aac9711d 100644
--- a/components/subresource_filter/core/common/document_subresource_filter.cc
+++ b/components/subresource_filter/core/common/document_subresource_filter.cc
@@ -51,9 +51,21 @@ DocumentSubresourceFilter::DocumentSubresourceFilter(
url::Origin document_origin,
ActivationState activation_state,
scoped_refptr<const MemoryMappedRuleset> ruleset)
+ : DocumentSubresourceFilter(document_origin,
+ activation_state,
+ ruleset,
+ nullptr) {}
+
+DocumentSubresourceFilter::DocumentSubresourceFilter(
+ url::Origin document_origin,
+ ActivationState activation_state,
+ scoped_refptr<const MemoryMappedRuleset> ruleset,
+ std::unique_ptr<RuleRecorder> recorder)
: activation_state_(activation_state),
ruleset_(std::move(ruleset)),
- ruleset_matcher_(ruleset_->data(), ruleset_->length()) {
+ ruleset_matcher_(ruleset_->data(),
+ ruleset_->length(),
+ std::move(recorder)) {
DCHECK_NE(activation_state_.activation_level, ActivationLevel::DISABLED);
if (!activation_state_.filtering_disabled_for_document)
document_origin_.reset(new FirstPartyOrigin(std::move(document_origin)));

Powered by Google App Engine
This is Rietveld 408576698