components/subresource_filter/core/browser/subresource_filter_features.cc - Issue 2894523006: Add instrumentation hooks to mesaure which subresource filter rules are used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features.cc

Issue 2894523006: Add instrumentation hooks to mesaure which subresource filter rules are used.

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/web_document_subresource_filter_impl.cc ('k') | components/subresource_filter/core/common/document_subresource_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features.cc

diff --git a/components/subresource_filter/core/browser/subresource_filter_features.cc b/components/subresource_filter/core/browser/subresource_filter_features.cc

index 5ce505d10bf931e2536b9ee84c3ce012ceb22adf..5a2dae7ebb3063844a5acb57388346bdff254afa 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features.cc

+++ b/components/subresource_filter/core/browser/subresource_filter_features.cc

@@ -121,7 +121,7 @@ std::vector<Configuration> FillEnabledPresetConfigurations(

} kAvailablePresetConfigurations[] = {

{kPresetLiveRunOnPhishingSites, false,

&Configuration::MakePresetForLiveRunOnPhishingSites},

- {kPresetPerformanceTestingDryRunOnAllSites, false,

+ {kPresetPerformanceTestingDryRunOnAllSites, true,

&Configuration::MakePresetForPerformanceTestingDryRunOnAllSites}};

CommaSeparatedStrings enabled_presets(

@@ -145,6 +145,7 @@ Configuration ParseExperimentalConfiguration(

std::map<std::string, std::string>* params) {

Configuration configuration;

+ LOG(ERROR) << "ParseExperimentalConfigurations";

// ActivationConditions:

configuration.activation_conditions.activation_scope = ParseActivationScope(

TakeVariationParamOrReturnEmpty(params, kActivationScopeParameterName));