Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 2894163002: [subresource_filter] |enable_logging| should be part of the IPC with ActivationState (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by shivanisha
Modified:
1 month, 1 week ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

|enable_logging| should be part of the IPC with ActivationState. BUG=724549 Review-Url: https://codereview.chromium.org/2894163002 Cr-Commit-Position: refs/heads/master@{#473342} Committed: https://chromium.googlesource.com/chromium/src/+/1315a0fb48bc85823b8072b56abbe38dfcf1679f

Patch Set 1 #

Messages

Total messages: 18 (11 generated)
shivanisha
PTAL, Thanks!
1 month, 1 week ago (2017-05-19 17:41:30 UTC) #5
Charlie Harrison
LGTM but you'll need an IPC owner too
1 month, 1 week ago (2017-05-19 17:44:05 UTC) #6
Charlie Harrison
Would you add a BUG= though?
1 month, 1 week ago (2017-05-19 17:45:03 UTC) #7
shivanisha
dcheng@, PTAL for owner's approval, Thanks!
1 month, 1 week ago (2017-05-19 17:51:55 UTC) #10
dcheng (OOO Jun 25 - Jul 1)
lgtm lgtm
1 month, 1 week ago (2017-05-19 21:42:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894163002/1
1 month, 1 week ago (2017-05-19 21:43:20 UTC) #15
commit-bot: I haz the power
1 month, 1 week ago (2017-05-19 21:49:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1315a0fb48bc85823b8072b56abb...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318