Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2656)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2887773008: Update fullscreen ux, make floor and ceiling visible. (Closed)
Patch Set: adjust tests to fail if a new added element becomes visible at some future point Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index cf091eacd8dcd6e05ea5084b7a4e6750d4b34d2d..3281ba4e7ada753a36c7eb00877c0a10b805312f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -68,9 +68,10 @@ public class VrShellImpl
// text too small to read.
private static final float DEFAULT_CONTENT_WIDTH = 960f;
private static final float DEFAULT_CONTENT_HEIGHT = 640f;
- // Make full screen 16:9 while maintaining same width as default.
- private static final float FULLSCREEN_CONTENT_WIDTH = 960f;
- private static final float FULLSCREEN_CONTENT_HEIGHT = 540f;
+
+ // Make full screen 16:9 until we get exact dimensions from playing video.
+ private static final float FULLSCREEN_CONTENT_WIDTH = 1024f;
+ private static final float FULLSCREEN_CONTENT_HEIGHT = 576f;
private final ChromeActivity mActivity;
private final VrShellDelegate mDelegate;
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698