[Android] Adding content settings provider for notification channels

chrome/browser/notifications/notification_channels_provider_android.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/notification_channels_provider_android.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
+#include "base/logging.h"
+#include "base/strings/string_util.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/content_settings/core/browser/content_settings_details.h"
+#include "components/content_settings/core/browser/content_settings_utils.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/content_settings/core/common/content_settings.h"
+#include "components/content_settings/core/common/content_settings_pattern.h"
+#include "jni/NotificationSettingsBridge_jni.h"
+#include "url/gurl.h"
+#include "url/url_constants.h"
+
+using base::android::AttachCurrentThread;
+using base::android::ConvertUTF8ToJavaString;
+using base::android::ScopedJavaLocalRef;
+
+namespace {

[raymes, 2017/05/24 00:59:50]

nit: newline after this

[awdf, 2017/06/01 15:11:21]

Done.

+class NotificationChannelsBridgeImpl
+    : public NotificationChannelsProviderAndroid::NotificationChannelsBridge {
+ public:
+  NotificationChannelsBridgeImpl() = default;
+  ~NotificationChannelsBridgeImpl() override = default;
+
+  bool ShouldUseChannelSettings() override {
+    return Java_NotificationSettingsBridge_shouldUseChannelSettings(
+        AttachCurrentThread());
+  }
+
+  void CreateChannel(const std::string& origin, bool enabled) {
+    JNIEnv* env = AttachCurrentThread();
+    Java_NotificationSettingsBridge_createChannel(
+        env, ConvertUTF8ToJavaString(env, origin), enabled);
+  }
+
+  NotificationChannelStatus GetChannelStatus(const std::string& origin) {
+    JNIEnv* env = AttachCurrentThread();
+    return static_cast<NotificationChannelStatus>(
+        Java_NotificationSettingsBridge_getChannelStatus(
+            env, ConvertUTF8ToJavaString(env, origin)));
+  }
+
+  void DeleteChannel(const std::string& origin) {
+    JNIEnv* env = AttachCurrentThread();
+    Java_NotificationSettingsBridge_deleteChannel(
+        env, ConvertUTF8ToJavaString(env, origin));
+  }
+};
+
+}  // anonymous namespace
+
+NotificationChannelsProviderAndroid::NotificationChannelsProviderAndroid()
+    : NotificationChannelsProviderAndroid(
+          base::MakeUnique<NotificationChannelsBridgeImpl>()) {}
+
+NotificationChannelsProviderAndroid::NotificationChannelsProviderAndroid(
+    std::unique_ptr<NotificationChannelsBridge> bridge)
+    : bridge_(std::move(bridge)),
+      should_use_channels_(bridge_->ShouldUseChannelSettings()) {}
+
+NotificationChannelsProviderAndroid::~NotificationChannelsProviderAndroid() =
+    default;
+
+std::unique_ptr<content_settings::RuleIterator>
+NotificationChannelsProviderAndroid::GetRuleIterator(
+    ContentSettingsType content_type,
+    const content_settings::ResourceIdentifier& resource_identifier,
+    bool incognito) const {
+  // TODO(crbug.com/700377) return rule iterator over all channels
+  return nullptr;
+}
+
+bool NotificationChannelsProviderAndroid::SetWebsiteSetting(
+    const ContentSettingsPattern& primary_pattern,
+    const ContentSettingsPattern& secondary_pattern,
+    ContentSettingsType content_type,
+    const content_settings::ResourceIdentifier& resource_identifier,
+    base::Value* value) {
+  if (content_type != CONTENT_SETTINGS_TYPE_NOTIFICATIONS ||
+      !should_use_channels_) {
+    return false;
+  }
+  GURL primary_url = GURL(primary_pattern.ToString());
+  DCHECK(primary_url.is_valid());
+  const std::string origin = primary_url.spec();

[raymes, 2017/05/24 00:59:51]

One thing I didn't consider earlier:
Some valid non-wildcard patterns are actually not origins. For example
file:///path/x patterns are valid. I don't think these work on Android
notifications though.

It may be better to do this:
std::string origin = primary_pattern.ToString();
DCHECK(!url::Origin(GURL(origin)).is_unique());

That will give us firmer guarantees and we can loosen the restrictions later if
need (though I don't suspect we will need to for android). Also I don't think we
really need to use the output of .spec() as the stored representation. It's
going to have to be put back into a ContentSettingsPattern anyway at the end of
the day so it doesn't seem necessary to take the GURL parsed version.

[awdf, 2017/06/01 15:11:21]

Done.
I used spec() in case SetWebsiteSetting gets called twice for conceptually the
same origin but different 'pattern.ToString()'s, so that we don't end up with
two channels for the same origin.

+  ContentSetting setting = content_settings::ValueToContentSetting(value);
+  switch (setting) {
+    case CONTENT_SETTING_ALLOW:
+    case CONTENT_SETTING_BLOCK: {
+      auto channel_status = bridge_->GetChannelStatus(origin);
+      if (channel_status == NotificationChannelStatus::UNAVAILABLE) {
+        bridge_->CreateChannel(origin,
+                               setting == CONTENT_SETTING_ALLOW /* enabled */);
+      } else {
+        DCHECK(!(setting == CONTENT_SETTING_ALLOW &&
+                 channel_status == NotificationChannelStatus::BLOCKED));
+        DCHECK(!(setting == CONTENT_SETTING_BLOCK &&
+                 channel_status == NotificationChannelStatus::ENABLED));
+      }
+      break;
+    }
+    case CONTENT_SETTING_DEFAULT:
+      bridge_->DeleteChannel(origin);
+      break;
+    default:
+      // We rely on notification settings being one of ALLOW/BLOCK/DEFAULT.
+      NOTREACHED();
+      break;
+  }
+  return true;
+}
+
+void NotificationChannelsProviderAndroid::ClearAllContentSettingsRules(
+    ContentSettingsType content_type) {
+  // TODO(crbug.com/700377): If |content_type| == NOTIFICATIONS, delete
+  // all channels.
+}
+
+void NotificationChannelsProviderAndroid::ShutdownOnUIThread() {
+  RemoveAllObservers();
+}