cc : Create effect nodes for non axis aligned clips

cc/trees/layer_tree_host_common_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_common.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 1323 matching lines @@
   draws_content->SetBounds(gfx::Size(10, 10));
   draws_content->SetDrawsContent(true);
 
   ExecuteCalculateDrawProperties(root);
   EffectTree& effect_tree =
       root->layer_tree_impl()->property_trees()->effect_tree;
   EffectNode* node = effect_tree.Node(clips_subtree->effect_tree_index());
   EXPECT_TRUE(node->has_render_surface);
 }
 
+TEST_F(LayerTreeHostCommonTest, EffectNodesForNonAxisAlignedClips) {
+  LayerImpl* root = root_layer_for_testing();
+  LayerImpl* rotate_and_clip = AddChildToRoot<LayerImpl>();
+  LayerImpl* only_clip = AddChild<LayerImpl>(rotate_and_clip);
+  LayerImpl* rotate_and_clip2 = AddChild<LayerImpl>(only_clip);
+
+  gfx::Transform rotate;
+  rotate.Rotate(2);
+  root->SetBounds(gfx::Size(10, 10));
+  rotate_and_clip->SetBounds(gfx::Size(10, 10));
+  rotate_and_clip->test_properties()->transform = rotate;
+  rotate_and_clip->SetMasksToBounds(true);
+  only_clip->SetBounds(gfx::Size(10, 10));
+  only_clip->SetMasksToBounds(true);
+  rotate_and_clip2->SetBounds(gfx::Size(10, 10));
+  rotate_and_clip2->test_properties()->transform = rotate;
+  rotate_and_clip2->SetMasksToBounds(true);
+
+  ExecuteCalculateDrawProperties(root);
+  // non-axis aligned clip should create an effect node
+  EXPECT_NE(root->effect_tree_index(), rotate_and_clip->effect_tree_index());
+  // Since only_clip's clip is in the same non-axis aligned space as
+  // rotate_and_clip's clip, no new effect node should be created.
+  EXPECT_EQ(rotate_and_clip->effect_tree_index(),
+            only_clip->effect_tree_index());
+  // rotate_and_clip2's clip and only_clip's clip are in different non-axis
+  // aligned spaces. So, new effect node should be created.
+  EXPECT_NE(rotate_and_clip2->effect_tree_index(),
+            only_clip->effect_tree_index());
+}
+
 TEST_F(LayerTreeHostCommonTest,
        RenderSurfaceListForRenderSurfaceWithClippedLayer) {
   LayerImpl* root = root_layer_for_testing();
   LayerImpl* render_surface1 = AddChildToRoot<LayerImpl>();
   LayerImpl* child = AddChild<LayerImpl>(render_surface1);
 
   root->SetBounds(gfx::Size(10, 10));
   root->SetMasksToBounds(true);
   render_surface1->SetBounds(gfx::Size(10, 10));
   render_surface1->test_properties()->force_render_surface = true;
@@ skipping 8824 matching lines @@
 
   // Check child layer draw properties.
   EXPECT_EQ(gfx::Rect(10, 10), child->visible_layer_rect());
   EXPECT_EQ(gfx::Transform(), child->DrawTransform());
   EXPECT_EQ(gfx::Rect(10, 10), child->clip_rect());
   EXPECT_EQ(gfx::Rect(10, 10), child->drawable_content_rect());
 }
 
 }  // namespace
 }  // namespace cc