Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)
Patch Set: nit addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index feba7c0149f4ca685e2a7fb8c756e41b86deeec4..16807077fa59ad1eddc26ab69680f417765016fd 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -122,6 +122,9 @@ class CORE_EXPORT LocalFrame final : public Frame,
void PrintNavigationWarning(const String&) override;
bool PrepareForCommit() override;
void DidChangeVisibilityState() override;
+ // This sets the is_inert_ flag and also recurses through this frame's
+ // subtree, updating the inert bit on all descendant frames.
+ void SetIsInert(bool) override;
void DetachChildren();
void DocumentAttached();
@@ -247,6 +250,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
std::unique_ptr<WebURLLoader> CreateURLLoader();
+ bool IsInert() const { return is_inert_; }
+
using FrameInitCallback = void (*)(LocalFrame*);
// Allows for the registration of a callback that is invoked whenever a new
// LocalFrame is initialized. Callbacks are executed in the order that they
@@ -287,6 +292,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
bool CanNavigateWithoutFramebusting(const Frame&, String& error_reason);
+ void PropagateInertToChildFrames();
+
std::unique_ptr<WebFrameScheduler> frame_scheduler_;
mutable FrameLoader loader_;
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698