Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)
Patch Set: Rebase only Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html
diff --git a/third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html b/third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html
index 64815f7f67e3cd17352cadff52af2a9d4f77ea35..abbc38998dcf7d9ebb2d046c0bcfcaa9198dd580 100644
--- a/third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html
+++ b/third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames.html
@@ -39,13 +39,17 @@ function test() {
frame1.querySelector('dialog').showModal();
testFocus(frame1.querySelector('.target'), false);
- var iframe = frame1.querySelector('iframe').contentDocument;
+ var iframe = frame1.querySelector('#iframe1').contentDocument;
testFocus(iframe.querySelector('.target'), false);
debug('Even a modal dialog in the iframe is blocked by the modal dialog in the parent frame1.');
iframe.querySelector('dialog').showModal();
testFocus(iframe.querySelector('button'), false);
+ debug('An iframe within a modal dialog can still be focused.');
+ var dialogIframe = frame1.querySelector('#iframe-in-dialog').contentDocument;
+ testFocus(dialogIframe.querySelector('.target'), true);
+
debug('A modal dialog does not block nodes in a sibling frame.');
var frame2 = mainIframe.contentWindow.frames[1].document;
testFocus(frame2.querySelector('.target'), true);

Powered by Google App Engine
This is Rietveld 408576698