Propagate inert state to OOPIFs when a modal dialog is active

third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
 #include "core/html/HTMLDialogElement.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/AXObjectCache.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLFormControlElement.h"
+#include "core/html/HTMLFrameOwnerElement.h"
 #include "core/style/ComputedStyle.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 // This function chooses the focused element when show() or showModal() is
 // invoked, as described in their spec.
 static void SetFocusForDialog(HTMLDialogElement* dialog) {
   Element* focusable_descendant = nullptr;
@@ skipping 28 matching lines @@
 
   if (dialog->IsFocusable()) {
     dialog->focus();
     return;
   }
 
   dialog->GetDocument().ClearFocusedElement();
 }
 
 static void InertSubtreesChanged(Document& document) {
+  if (document.GetFrame()) {

[dmazzoni, 2017/05/19 18:58:19]

Perhaps this deserves a comment saying that this is what
propagates the state to all child frames?

[kenrb, 2017/05/31 18:32:00]

Done.

+    document.GetFrame()->SetIsInert(document.LocalOwner() &&
+                                    document.LocalOwner()->IsInert());
+  }
+
   // When a modal dialog opens or closes, nodes all over the accessibility
   // tree can change inertness which means they must be added or removed from
   // the tree. The most foolproof way is to clear the entire tree and rebuild
   // it, though a more clever way is probably possible.
   document.ClearAXObjectCache();
   if (AXObjectCache* cache = document.AxObjectCache())
     cache->ChildrenChanged(&document);
 }
 
 inline HTMLDialogElement::HTMLDialogElement(Document& document)
@@ skipping 81 matching lines @@
   // is thrown away.
   InertSubtreesChanged(GetDocument());
 
   ForceLayoutForCentering();
   SetFocusForDialog(this);
 }
 
 void HTMLDialogElement::RemovedFrom(ContainerNode* insertion_point) {
   HTMLElement::RemovedFrom(insertion_point);
   SetNotCentered();
-  // FIXME: We should call inertSubtreesChanged() here.
+  InertSubtreesChanged(GetDocument());
 }
 
 void HTMLDialogElement::SetCentered(LayoutUnit centered_position) {
   DCHECK_EQ(centering_mode_, kNeedsCentering);
   centered_position_ = centered_position;
   centering_mode_ = kCentered;
 }
 
 void HTMLDialogElement::SetNotCentered() {
   centering_mode_ = kNotCentered;
@@ skipping 13 matching lines @@
 void HTMLDialogElement::DefaultEventHandler(Event* event) {
   if (event->type() == EventTypeNames::cancel) {
     CloseDialog();
     event->SetDefaultHandled();
     return;
   }
   HTMLElement::DefaultEventHandler(event);
 }
 
 }  // namespace blink