Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

Issue 2881203002: [subresource_filter] Add Page Info subtitle on desktop + placeholder string (Closed)
Patch Set: lgarron review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/page_info/page_info_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
index 29e33ec9d5b8d516091256cfc4371f80122bbf18..24a005e9f8ccdaf1eb303accc3bbf8215f205846 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
@@ -623,10 +623,10 @@ public class PageInfoPopup implements OnClickListener {
// The subresource filter permission requires an additional static subtitle.
if (permission.type == ContentSettingsType.CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER) {
- TextView permissionUnavailable =
+ TextView permissionSubtitle =
(TextView) permissionRow.findViewById(R.id.page_info_permission_subtitle);
- permissionUnavailable.setVisibility(View.VISIBLE);
- permissionUnavailable.setText(R.string.subresource_filter_permission_title);
+ permissionSubtitle.setVisibility(View.VISIBLE);
+ permissionSubtitle.setText(R.string.page_info_permission_subresource_filter_subtitle);
}
TextView permissionStatus = (TextView) permissionRow.findViewById(
« no previous file with comments | « no previous file | chrome/browser/ui/page_info/page_info_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698