Stability instrumentation Crashpad integration

headless/app/headless_shell.cc

Index: headless/app/headless_shell.cc
diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc
index d62a8cd8409cdf5bd03c8811651753433d6ad6d6..4fccf6040a3ed752105834cb93d8a8841f8b3cf9 100644
--- a/headless/app/headless_shell.cc
+++ b/headless/app/headless_shell.cc
@@ -549,7 +549,8 @@ int HeadlessShellMain(HINSTANCE instance,
           ::switches::kProcessType);
   if (process_type == crash_reporter::switches::kCrashpadHandler) {
     return crash_reporter::RunAsCrashpadHandler(
-        *base::CommandLine::ForCurrentProcess(), ::switches::kProcessType);
+        *base::CommandLine::ForCurrentProcess(), base::FilePath(),
+        ::switches::kProcessType, switches::kUserDataDir);

[grt (UTC plus 2), 2017/05/24 06:58:49]

uber-nit: "::switches::kUserDataDir" for consistency with kProcessType

[manzagop (departed), 2017/05/24 13:19:53]

Actually, that second one is in the headless namespace
(headless::switches::kUserDataDir from headless/app/headless_shell_switches.h).
Should I fully qualify it to make it clearer?

[grt (UTC plus 2), 2017/05/24 13:35:02]

Ha. Hrm. I'd be inclined to remove :: from the first, but I'm okay with it
as-is.

[alex clarke (OOO till 29th), 2017/05/24 13:45:06]

I don't know why this code is using ::
If it compiles without I'd prefer that, but its not a big deal :)

[manzagop (departed), 2017/05/24 15:40:29]

Hm, I think the author's intent was to highlight this is coming from
content/public/common/content_switches.h, and not headless::switches. Based on
that, is your preference still the same? I'm happy to go with  either.

[alex clarke (OOO till 29th), 2017/05/24 16:30:48]

Ah yes you're probably right.  Lets leave it as is then.

   }
 #endif  // defined(HEADLESS_USE_CRASPHAD)
   RunChildProcessIfNeeded(instance, sandbox_info);